JaneliaAPIG / spoke

Live display of neural spike data for SpikeGLX software
http://janeliaapig.github.io/spoke/
Other
3 stars 2 forks source link

Stimulus triggered waveform display (Hantman Lab) #32

Closed edkangdev closed 7 years ago

edkangdev commented 8 years ago

sync signal, clarify mode - is it similar to, or the same as gate mode? Or is gate mode a precondition for implementation?

JaneliaAPIG commented 8 years ago

Austin Graves in Hantman lab requests this feature. It's a hybrid of the classic Waveform & Raster display modes. It's Waveform display mode, but with the selective display based on a (common) stimulus channel, rather than spike detection at each channel.

Since Raster mode already implements stimulus triggering, user implementation would use the same stimulus channel property that's specified for Raster mode.

JaneliaAPIG commented 8 years ago

If stimulus is never detected, there will never be anything displayed. Only display the signal whenever the stimulus is detected.

JaneliaAPIG commented 8 years ago

This feature is basically no longer spike detection.

vijayiyer05 commented 8 years ago

Appears fixed as of e283c9f3b38183c6d8eaa6850828d2d563698e3e

needs bench testing; also need to check to see if raster mode is still working after all the changes

vijayiyer05 commented 7 years ago

Appears working as of cfe63442a7fee757329cd2b858d02cc5fd9523e4

vijayiyer05 commented 7 years ago

Future issues discovered during work on this issue:

vijayiyer05 commented 7 years ago

Rig demo uncovered a sporadic issue with stim-triggered waveform. Fixed as of fbf8107f17ec2418613c543e2f8ef63051ef3f1e. Tested on rig.

Commit 2df4564daafdb7cfc4faca1b427751f4bbb5aaed cleans up that fix in the code. Tested on bench, though not yet on rig. Presumed working.