Open WeissShahaf opened 5 years ago
Hi @WeissShahaf, can you let me know what's the git commit hash of the version you're running, and maybe show me a screenshot?
i'm running the latest commit, SHA 5e8f020e4a1adacf8eccaa258836c4c86de702fd
Makes sense now. This could be a bug in how the features for the feature projection view are sampled. Let me investigate and get back to you.
Hey, please give the latest commit a pull and let me know if you still see this problem.,
-some weird behavior now: projection plot now is displaying spikes for some clusters but not others. though it shows background spikes for all:
-when i try splitting it fails:
Warning: Failed to split: Operands to the || and && operators must be convertible to logical scalar values.
In jrclust.curate.CurateController/splitCluster (line 16) In jrclust.curate.CurateController/splitPoly (line 68) In jrclust.curate.CurateController/keyPressFigProj (line 65) In jrclust.curate.CurateController/plotAllFigures>@(varargin)obj.keyPressFigProj(varargin{:}) (line 23)
-Also display wave waveforms is weird- mean waveforms seem flat, when waveforms are clearly not:
and when i try to split it fails
Can you pull the latest and run the following script for me?
hCfg = jrclust.Config('/path/to/your/params.prm'); % load your prm file
hCfg.autoRecover = 1; % set an optional parameter to try automatically fixing this
hJRC = JRC(hCfg);
hJRC.loadFiles(); % load bin files, res.mat, try to fix any data inconsistencies
hJRC.curate(); % inspect the results
it does split after the patch, sometimes, but still splitting in time. other cluster still fail to split.
console output: Warning: Failed to split: split indices exceed bounds
In jrclust.curate.CurateController/splitCluster (line 21) In jrclust.curate.CurateController/splitPoly (line 95) In jrclust.curate.CurateController/keyPressFigProj (line 65) In jrclust.curate.CurateController/plotAllFigures>@(varargin)obj.keyPressFigProj(varargin{:}) (line 23)
for some recordings the patch fails. especially if i try it after starting manual curation. then i get an error message about unstable statistics and that curation will likely not be possible.
That surprises me. I'm inclined to think it's something particular to your dataset. May I take a look at it?
Also, you mentioned it only sometimes splits? What happens when it doesn't?
if the split fails it says operation failed.
Warning: Failed to split: split indices exceed bounds
In jrclust.curate.CurateController/splitCluster (line 21) In jrclust.curate.CurateController/splitPoly (line 95) In jrclust.curate.CurateController/keyPressFigProj (line 65) In jrclust.curate.CurateController/plotAllFigures>@(varargin)obj.keyPressFigProj(varargin{:}) (line 23)
here is a link to an example dataset test folder: https://www.dropbox.com/sh/36jcwu2n5qkkz5l/AADFZmVmHGaI40jBOXyUOHDWa?dl=0
when splitting clusters using feature projection, the split always seems to be a time cut off in addition to that, the clusters which appear to be distinct, are still present after cutting.
this happens on various computers, and recording sessions.
GL383_20190815_OF_g0_t0.imec0.ap.prm.zip
If you have a usage or support question, come join our Gitter and ask your question there. If you found a bug, please provide all of the following:
Output of
ver
The command you used
(e.g.,
jrc detect-sort myparam.prm
) jrc manualIf manually sorting, what it is you tried to do
split using Feature projection
Console output
2019-08-26 09:00:17 Computing cluster mean waveforms... 2019-08-26 09:00:17 Finished computing cluster mean waveforms (took 0.13 s) 2019-08-26 09:00:17 Computing waveform correlation... 2019-08-26 09:00:17 Finished computing waveform correlation (took 0.12 s) 2019-08-26 09:00:17 Computing cluster quality scores... 2019-08-26 09:00:17 Finished computing cluster quality scores (took 0.02 s)