Manual curation is slower in v4 compared to v3

[LiuDaveLiu]

Everything is much slower in the manual curation of v4 compared to v3. Merging and splitting takes 5s per action.

If you have a usage or support question, come join our Gitter and ask your question there. If you found a bug, please provide all of the following:

Output of ver

Same as before

Output of gpuDevice

Same as before

The command you used

(e.g., jrc detect-sort myparam.prm)

If manually sorting, what it is you tried to do

Merging units is much slower than in v3. Computing waveform correlation... took 1.7s Computing self correlation ................................................................................................................................................................................................................................................................................................................................................................................................................ took 4.9s Calculating cluster quality... took 0.1s Computing waveform correlation... took 3.1s Computing self correlation ............................................................................................................................................................................................................................................................................................................................................................................................................... took 4.9s Calculating cluster quality... took 0.0s Computing waveform correlation... took 0.2s Computing self correlation .............................................................................................................................................................................................................................................................................................................................................................................................................. took 4.9s Calculating cluster quality... took 0.0s Computing waveform correlation... took 0.1s Computing self correlation ............................................................................................................................................................................................................................................................................................................................................................................................................. took 5.2s Calculating cluster quality... took 0.1s Computing waveform correlation... took 3.9s Computing self correlation ............................................................................................................................................................................................................................................................................................................................................................................................................ took 5.6s Calculating cluster quality... took 0.0s

Console output

[aliddell]

I'll need to profile this and see where the bottleneck is.

[jamesjun]

Try running ‘jrc unit-test manual’ and it should create a profiler report. It should be compared between version 3 and 4 to determine what’s slowing down.

-James

On Feb 8, 2019, at 8:27 PM, LiuDaveLiu notifications@github.com wrote:

Everything is much slower in the manual curation of v4 compared to v3. Merging, splitting, saving, etc.

If you have a usage or support question, come join our Gitter and ask your question there. If you found a bug, please provide all of the following:

Output of ver

Same as before

Output of gpuDevice

Same as before

The command you used

(e.g., jrc detect-sort myparam.prm)

If manually sorting, what it is you tried to do

Merging units is much slower than in v3. Computing waveform correlation... took 1.7s Computing self correlation ................................................................................................................................................................................................................................................................................................................................................................................................................ took 4.9s Calculating cluster quality... took 0.1s Computing waveform correlation... took 3.1s Computing self correlation ............................................................................................................................................................................................................................................................................................................................................................................................................... took 4.9s Calculating cluster quality... took 0.0s Computing waveform correlation... took 0.2s Computing self correlation .............................................................................................................................................................................................................................................................................................................................................................................................................. took 4.9s Calculating cluster quality... took 0.0s Computing waveform correlation... took 0.1s Computing self correlation ............................................................................................................................................................................................................................................................................................................................................................................................................. took 5.2s Calculating cluster quality... took 0.1s Computing waveform correlation... took 3.9s Computing self correlation ............................................................................................................................................................................................................................................................................................................................................................................................................ took 5.6s Calculating cluster quality... took 0.0s

Console output

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[aliddell]

Will do

[aliddell]

This is partially addressed in 4539c5f2bd5dc06b6743b7c1cfabbd0998075493. Auto-merge is still much slower, that's a work in progress.