Fix property name truncation in getproperties()

JaneliaSciComp / NIDAQ.jl

National Instruments Data Acquisition Interface

Other

47 stars 16 forks source link

Fix property name truncation in getproperties() #23

Closed urlicht closed 4 years ago

urlicht commented 4 years ago

Resolving issue #22

bjarthur commented 4 years ago

thanks for the contribution! but, this used to not be a problem. what is different do you think?

urlicht commented 4 years ago

I just checked, and the problem is julia version dependent. On v1.0.5, it functions fine as is, but the proposed fix is required for v1.2.0 or later. I won't be able to debug it to find the exact source at the moment, but perhaps some changes were made in julia ccall between v1.0.5 and v1.2.0?

bjarthur commented 4 years ago

VERSION >= v"1.2" ? 15 : 9 maybe?

urlicht commented 4 years ago

I haven't had time to debug the problem, but I included your proposed version dependent change to the fix.

bjarthur commented 4 years ago

thanks!