search

JaneliaSciComp / NIDAQ.jl

National Instruments Data Acquisition Interface
Other
47 stars 16 forks source link

Cjg/usb 6002 #8

Closed Cody-G closed 7 years ago

Cody-G commented 7 years ago

Modifies the test script so that devices without buffered digital input / output and counter output can pass.

bjarthur commented 7 years ago

looks great. thanks for this. just a couple of small suggestions. also, could you please shorten up the commit messages so they aren't wrapped/truncated?

Cody-G commented 7 years ago

Thanks for the review! I think I've addressed everything in the amended commits, but I don't have access to a device today to test. I'll test asap and let you know.

Cody-G commented 7 years ago

Sorry, I've been traveling and hardware access has been difficult. I'll change according to your suggestion and test on my box tomorrow.

On Wed, Jul 19, 2017 at 7:46 AM, Ben Arthur notifications@github.com wrote:

@bjarthur commented on this pull request.

In test/runtests.jl https://github.com/JaneliaSciComp/NIDAQ.jl/pull/8#discussion_r128234683:

@@ -112,18 +118,24 @@ else @test start(t) == nothing @test write(t, round.(UInt8, [1 0; 0 0; 1 0; 0 1; 1 1; 0 1])) == 6 @test stop(t) == nothing

  • @test NIDAQ.CfgSampClkTiming(t.th, convert(Ref{UInt8},b""), 100.0, NIDAQ.Val_Rising,
  • rslt = Ref{UInt32}(0)
  • NIDAQ.DAQmxGetBufInputOnbrdBufSize(t.th, rslt)

should be DAQmxGetBufOutputOnbrdBufSize, not ...Input.... otherwise, this works on my box. did you get a chance to test on yours?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JaneliaSciComp/NIDAQ.jl/pull/8#pullrequestreview-50893722, or mute the thread https://github.com/notifications/unsubscribe-auth/AE78hD1bdZxOjOJtviiQA1RrQtF3eTMgks5sPfqsgaJpZM4OELO0 .

bjarthur commented 7 years ago

would be great if you could also test https://github.com/JaneliaSciComp/NIDAQ.jl/pull/9 with your apps before i merge it. thanks.

Cody-G commented 7 years ago

Okay this should be good to go! I also rebased your work in #9 on this (only locally), installed NIDAQmx v17.1, and ran the tests with my device. Tests passed!