grid pattern misalignment after local affines

JaneliaSciComp / bigstream

Tools for distributed alignment of massive images

BSD 3-Clause "New" or "Revised" License

74 stars 21 forks source link

grid pattern misalignment after local affines #8

Open tatz-murakami opened 2 years ago

tatz-murakami commented 2 years ago

I followed the example bigstream_intro_tutorial jupyter notebook with the default parameters. The registration looks fine after global affine. However, weird grid pattern misalignment appeared after local affines. This happens even if I define local affines filled with identity matrices. I am not familiar with dask, but I suspect the merging of overlapping regions between chunks is causing the problem.

global affine global_affine

global + local affines total_affine

MathieuBo commented 2 years ago

Hello, I obtained a similar issue. Did you find a way to resolve it?

Thanks!

orena1 commented 2 years ago

Hi @MathieuBo and @tatz-murakami From what I can tell there is a off-by-one bug in dask_stitch, I've fixed it and it looks fine:

See bug fix @GFleishman https://github.com/GFleishman/dask_stitch/pull/1