search

JaneySprings / DotNet.Meteor

A VSCode extension that can run and debug .NET apps (Xamarin, MAUI, Avalonia)
https://marketplace.visualstudio.com/items?itemName=nromanov.dotnet-meteor
MIT License
269 stars 10 forks source link

Can't Detect Physical iPad Device #57

Closed Tranquilite0 closed 1 year ago

Tranquilite0 commented 1 year ago

.NET Meteor doesn't detect my physical iPad. I had a quick look through the code, and I think the problem is in the regex for detecting physical Apple devices, which appears to only match iPhone, and does not match iPad. The code in question:

https://github.com/JaneySprings/DotNet.Meteor/blob/40886bd66c169092fa3c990c18a0b639929dc40f/src/DotNet.Meteor.Shared/Apple/SystemProfiler.cs#LL12C1-L12C115

To detect iPads, I'm pretty sure the only thing that needs to happen is modify the Regex to look for "(iPhone|iPad):". You'll probably also want to create a capture group of that part to populate the device name too since it is currently hard coded to be an iPhone too.

JaneySprings commented 1 year ago

Hi, @Tranquilite0! Thank you for your issue. I had fixed this bug in fc68cb6. I will publish a release as soon as possible.