search

JangoSteve / remotipart

Rails jQuery file uploads via standard Rails "remote: true" forms.
http://os.alfajango.com/remotipart
Other
1k stars 215 forks source link

jQuery3 compatibility #162

Closed spdawson closed 6 years ago

spdawson commented 8 years ago

Do not call complete on object returned from jQuery.ajax; see #161

existent-ltd commented 8 years ago

This issue is also affecting us; any chance of getting this PR merged, and a new gem version released?

spdawson commented 7 years ago

Is there anything I can do to get this merged?

clairity commented 7 years ago

thanks @spdawson ! manually implementing this change made remotipart work for me (rails 5.0.1, jquery3).

iarie commented 7 years ago

@spdawson i'am using your solution, thanks! This bug almost made me quit the idea of using remotipart :/ ps: rails 5.0.1/ JQuery3

penapono commented 7 years ago

I'm getting a SyntaxError: missing ; before statement, any hints on this? Thanks

kayla-glick commented 6 years ago

@JangoSteve @mshibuya This is a pretty glaring issue nearly 2 years after the release of jQuery 3. If @spdawson 's solution fixes the problem, can this please be merged soon, or at least reviewed? This PR has been up for 1 1/2 years and this issue is affecting many users of remotipart.

Thanks again @spdawson for your solution. I will be using your fork for now as well.

JangoSteve commented 6 years ago

You're right! I'll take a look, merge it, and release a new version.