JangoSteve / remotipart

Rails jQuery file uploads via standard Rails "remote: true" forms.
http://os.alfajango.com/remotipart
Other
1k stars 215 forks source link

Firefox 49.0.1 #163

Closed silvioffilho closed 8 years ago

silvioffilho commented 8 years ago

Hi,

the file upload using ajax not work on firefox 49.0.1, when the file is select on view and the submit button is clicked the firefox not process de ajax request, the status returned is canceled

In firefox 48.0.2 works perfectly.

Tranks.

error_firefox
svelep commented 8 years ago

+1

teksetter commented 8 years ago

+1

nagybence commented 8 years ago

+1

boris-graeff commented 8 years ago

+1

StephaneRob commented 8 years ago

+1

StephaneRob commented 8 years ago

Load event is not fired https://github.com/JangoSteve/remotipart/blob/master/vendor/assets/javascripts/jquery.iframe-transport.js#L186

and it seems load event is fired when we change the iframe src from javascript:false to about:blank.(https://github.com/JangoSteve/remotipart/blob/master/vendor/assets/javascripts/jquery.iframe-transport.js#L181)

mmeetsn commented 8 years ago

+1

tashua314 commented 8 years ago

+1

stefansjs6 commented 8 years ago

+1

epifanov commented 8 years ago

+1

krubinshteyn commented 8 years ago

+1

vzharkov commented 8 years ago

+1

epifanov commented 8 years ago

Hi fellows. Could you please say what is the status of this issue?

olegpetrenko commented 8 years ago

+1

ramonlg commented 8 years ago

+1

akaspick commented 8 years ago

Changing javascript:false to about:blank or removing the src attribute completely still doesn't seem to solve the issue for me. Anybody else have this working with either of these changes?

StephaneRob commented 8 years ago

@akaspick did you try directly in console ?

var iframe = $('<iframe src="javascript:false;"></iframe>');
iframe.bind('load', function(){alert()});
$('body').append(iframe);

and

var iframe = $('<iframe src="about:blank"></iframe>');  // without semicolon
iframe.bind('load', function(){alert()});
$('body').append(iframe);
akaspick commented 8 years ago

@StephaneRob about:blank without the semicolon was the key.

HunterMeyer commented 8 years ago

I wonder if it has anything to do with CVE-2016-5283 which was fixed in Firefox 49.

bjensen commented 8 years ago

+1. The fix proposed by @StephaneRob works for me.

Kendra commented 8 years ago

+1

adam-e-trepanier commented 8 years ago

@StephaneRob 's fix for about:blank seems to work for me.

mshibuya commented 8 years ago

Fixed by #165.

StephaneRob commented 8 years ago

@mshibuya maybe we can reopen this issue #165 doesn't seem to fix it.

twmills commented 8 years ago

I agree, doesn't fix it for me either.

svelep commented 8 years ago

+1, fix does not work. Please reopen this issue.

StephaneRob commented 8 years ago

Will be fixed in #166