search

JangoSteve / remotipart

Rails jQuery file uploads via standard Rails "remote: true" forms.
http://os.alfajango.com/remotipart
Other
1k stars 215 forks source link

in rails 5 remotipart is not working #170

Closed venkat501 closed 6 years ago

venkat501 commented 8 years ago

exception reentered

Extracted source (around line #25): 23 24 25 26 27 28

      payload[:exception] = [e.class.name, e.message]
      payload[:exception_object] = e
      raise e
    ensure
      finish_with_state listeners_state, name, payload
    end

Rails.root: /home/bitlasoft/workspace/ts/paybitla

Application Trace | Framework Trace | Full Trace activesupport (5.0.0.1) lib/active_support/notifications/instrumenter.rb:25:in rescue in instrument' activesupport (5.0.0.1) lib/active_support/notifications/instrumenter.rb:28:ininstrument' activesupport (5.0.0.1) lib/active_support/notifications.rb:164:in instrument' actionpack (5.0.0.1) lib/action_controller/metal/instrumentation.rb:30:inprocess_action' actionpack (5.0.0.1) lib/action_controller/metal/params_wrapper.rb:248:in process_action' activerecord (5.0.0.1) lib/active_record/railties/controller_runtime.rb:18:inprocess_action' actionpack (5.0.0.1) lib/abstract_controller/base.rb:126:in process' actionview (5.0.0.1) lib/action_view/rendering.rb:30:inprocess' actionpack (5.0.0.1) lib/action_controller/metal.rb:190:in dispatch' actionpack (5.0.0.1) lib/action_controller/metal.rb:262:indispatch' actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:50:in dispatch' actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:32:inserve' actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:39:in block in serve' actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:26:ineach' actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:26:in serve' actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:725:incall' /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/bundler/gems/remotipart-cd653ddc43bb/lib/remotipart/middleware.rb:32:in `call'

mshibuya commented 8 years ago

Is there any clue that remotipart is culprit? Can you paste full stack trace, including the exception message?

venkat501 commented 8 years ago

I am sending again error details

Completed 500 Internal Server Error in 71ms (ActiveRecord: 0.1ms)

DEPRECATION WARNING: Method to_hash is deprecated and will be removed in Rails 5.1, as ActionController::Parameters no longer inherits from hash. Using this deprecated behavior exposes potential security problems. If you continue to use this method you may be creating a security vulnerability in your app that can be exploited. Instead, consider using one of these documented methods which are not deprecated: http://api.rubyonrails.org/v5.0.0.1/classes/ActionController/Parameters.html (called from method_missing at /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/gems/actionpack-5.0.0.1/lib/action_controller/metal/strong_parameters.rb:618)

fatal (exception reentered):

activesupport (5.0.0.1) lib/active_support/notifications/instrumenter.rb:25:in rescue in instrument' activesupport (5.0.0.1) lib/active_support/notifications/instrumenter.rb:28:ininstrument' activesupport (5.0.0.1) lib/active_support/notifications.rb:164:in instrument' actionpack (5.0.0.1) lib/action_controller/metal/instrumentation.rb:30:inprocess_action' actionpack (5.0.0.1) lib/action_controller/metal/params_wrapper.rb:248:in process_action' activerecord (5.0.0.1) lib/active_record/railties/controller_runtime.rb:18:inprocess_action' actionpack (5.0.0.1) lib/abstract_controller/base.rb:126:in process' actionview (5.0.0.1) lib/action_view/rendering.rb:30:inprocess' actionpack (5.0.0.1) lib/action_controller/metal.rb:190:in dispatch' actionpack (5.0.0.1) lib/action_controller/metal.rb:262:indispatch' actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:50:in dispatch' actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:32:inserve' actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:39:in block in serve' actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:26:ineach' actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:26:in serve' actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:725:incall' /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/bundler/gems/remotipart-88d9a7d55bde/lib/remotipart/middleware.rb:32:in call' rack (2.0.1) lib/rack/etag.rb:25:incall' rack (2.0.1) lib/rack/conditional_get.rb:25:in call' rack (2.0.1) lib/rack/head.rb:12:incall' rack (2.0.1) lib/rack/session/abstract/id.rb:222:in context' rack (2.0.1) lib/rack/session/abstract/id.rb:216:incall' actionpack (5.0.0.1) lib/action_dispatch/middleware/cookies.rb:613:in call' actionpack (5.0.0.1) lib/action_dispatch/middleware/callbacks.rb:38:inblock in call' activesupport (5.0.0.1) lib/active_support/callbacks.rb:97:in __run_callbacks__' activesupport (5.0.0.1) lib/active_support/callbacks.rb:750:in_run_call_callbacks' activesupport (5.0.0.1) lib/active_support/callbacks.rb:90:in run_callbacks' actionpack (5.0.0.1) lib/action_dispatch/middleware/callbacks.rb:36:incall' actionpack (5.0.0.1) lib/action_dispatch/middleware/executor.rb:12:in call' actionpack (5.0.0.1) lib/action_dispatch/middleware/remote_ip.rb:79:incall' airbrake (3.1.13) lib/airbrake/rails/middleware.rb:13:in call' actionpack (5.0.0.1) lib/action_dispatch/middleware/debug_exceptions.rb:49:incall' web-console (3.3.1) lib/web_console/middleware.rb:131:in call_app' web-console (3.3.1) lib/web_console/middleware.rb:28:inblock in call' web-console (3.3.1) lib/web_console/middleware.rb:18:in catch' web-console (3.3.1) lib/web_console/middleware.rb:18:incall' actionpack (5.0.0.1) lib/action_dispatch/middleware/show_exceptions.rb:31:in call' railties (5.0.0.1) lib/rails/rack/logger.rb:36:incall_app' railties (5.0.0.1) lib/rails/rack/logger.rb:24:in block in call' activesupport (5.0.0.1) lib/active_support/tagged_logging.rb:70:inblock in tagged' activesupport (5.0.0.1) lib/active_support/tagged_logging.rb:26:in tagged' activesupport (5.0.0.1) lib/active_support/tagged_logging.rb:70:intagged' railties (5.0.0.1) lib/rails/rack/logger.rb:24:in call' sprockets-rails (3.2.0) lib/sprockets/rails/quiet_assets.rb:13:incall' actionpack (5.0.0.1) lib/action_dispatch/middleware/request_id.rb:24:in call' rack (2.0.1) lib/rack/method_override.rb:22:incall' rack (2.0.1) lib/rack/runtime.rb:22:in call' activesupport (5.0.0.1) lib/active_support/cache/strategy/local_cache_middleware.rb:28:incall' actionpack (5.0.0.1) lib/action_dispatch/middleware/executor.rb:12:in call' actionpack (5.0.0.1) lib/action_dispatch/middleware/static.rb:136:incall' rack (2.0.1) lib/rack/sendfile.rb:111:in call' airbrake (3.1.13) lib/airbrake/user_informer.rb:16:in_call' airbrake (3.1.13) lib/airbrake/user_informer.rb:12:in call' railties (5.0.0.1) lib/rails/engine.rb:522:incall' rack (2.0.1) lib/rack/handler/webrick.rb:86:in service' /home/bitlasoft/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/webrick/httpserver.rb:140:inservice' /home/bitlasoft/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/webrick/httpserver.rb:96:in run' /home/bitlasoft/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/webrick/server.rb:296:inblock in start_thread' Rendering /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout Rendering /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/templates/rescues/_source.html.erb Rendered /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/templates/rescues/_source.html.erb (2.5ms) Rendering /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb Rendered /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb (2.3ms) Rendering /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb Rendered /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb (2.0ms) Rendered /home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout (35.6ms)

venkat501 commented 8 years ago

If I am commenting the remotepart gem in gem file,then my application working fine

venkat501 commented 8 years ago

you can check following

/home/bitlasoft/.rvm/gems/ruby-2.3.1@rails-5.0.0.1/bundler/gems/remotipart-88d9a7d55bde/lib/remotipart/middleware.rb:32:

Bodacious commented 8 years ago

I'm seeing this same issue.

It's the change in MiddleWare in Rails 5.

4:39:52 PM web.1    |  [17996] ! Unable to load application: RuntimeError: No such middleware to insert after: ActionDispatch::ParamsParser
4:39:52 PM web.1    |  /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/stack.rb:108:in `assert_index': No such middleware to insert after: ActionDispatch::ParamsParser (RuntimeError)
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/stack.rb:80:in `insert_after'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/configuration.rb:69:in `block in merge_into'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/configuration.rb:68:in `each'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/configuration.rb:68:in `merge_into'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/engine.rb:507:in `block in app'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/engine.rb:504:in `synchronize'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/engine.rb:504:in `app'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/application/finisher.rb:37:in `block in <module:Finisher>'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/initializable.rb:30:in `instance_exec'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/initializable.rb:30:in `run'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/initializable.rb:55:in `block in run_initializers'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:228:in `block in tsort_each'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:431:in `each_strongly_connected_component_from'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:349:in `block in each_strongly_connected_component'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:347:in `each'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:347:in `call'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:347:in `each_strongly_connected_component'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:226:in `tsort_each'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:205:in `tsort_each'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/initializable.rb:54:in `run_initializers'
4:39:52 PM web.1    |   from /Users/Gavin/.rvm/gems/ruby-2.3.0/gems/railties-5.0.0.1/lib/rails/application.rb:352:in `initialize!

This only happens once I install remotipart.

Bodacious commented 8 years ago

I'm sorry, please ignore that last comment. I was running on a previously installed (old) version of remotipart.

1.3.1 works fine for me

anti-k-camino commented 7 years ago

1.3.1 works great. IMO there should be mentioned on main page bout specifying 1.3.1 in gemfile for 5-th.

pedroadame commented 7 years ago

1.3.1 doesn't work for me. Form is not submitted by remotipart and they're processed as HTML instead of JS.

Onidzuka commented 7 years ago

I am having the same issue with 1.3.1 and rails 5.1.2

Evanto commented 7 years ago

Hi, I'm having an ActionController::InvalidAuthenticityToken in AnswersController#create error with Rails 5.1.1. and Remotipart once I try to submit an answer with a file attachment via Ajax nested form (//= require jquery.remotipart comes right after //= require jquery_ujs in application.js as described in the docs). Any ideas how to go about it? Log:

Started POST "/questions/67/answers" for 10.0.2.2 at 2017-08-09 16:43:07 +0000
Cannot render console from 10.0.2.2! Allowed networks: 127.0.0.1, ::1, 127.0.0.0/127.255.255.255
Processing by AnswersController#create as HTML
  Parameters: {"utf8"=>"✓", "answer"=>{"body"=>"loo"}, "commit"=>"Post your answer", "question_id"=>"67"}
Can't verify CSRF token authenticity.
Completed 422 Unprocessable Entity in 1ms (ActiveRecord: 0.0ms)

ActionController::InvalidAuthenticityToken (ActionController::InvalidAuthenticityToken):

actionpack (5.1.1) lib/action_controller/metal/request_forgery_protection.rb:195:in `handle_unverified_request'
actionpack (5.1.1) lib/action_controller/metal/request_forgery_protection.rb:227:in `handle_unverified_request'
devise (4.3.0) lib/devise/controllers/helpers.rb:253:in `handle_unverified_request'
actionpack (5.1.1) lib/action_controller/metal/request_forgery_protection.rb:222:in `verify_authenticity_token'
activesupport (5.1.1) lib/active_support/callbacks.rb:413:in `block in make_lambda'
activesupport (5.1.1) lib/active_support/callbacks.rb:197:in `block (2 levels) in halting'
actionpack (5.1.1) lib/abstract_controller/callbacks.rb:12:in `block (2 levels) in <module:Callbacks>'
activesupport (5.1.1) lib/active_support/callbacks.rb:198:in `block in halting'
activesupport (5.1.1) lib/active_support/callbacks.rb:507:in `block in invoke_before'
activesupport (5.1.1) lib/active_support/callbacks.rb:507:in `each'
activesupport (5.1.1) lib/active_support/callbacks.rb:507:in `invoke_before'
activesupport (5.1.1) lib/active_support/callbacks.rb:130:in `run_callbacks'
actionpack (5.1.1) lib/abstract_controller/callbacks.rb:19:in `process_action'
actionpack (5.1.1) lib/action_controller/metal/rescue.rb:20:in `process_action'
actionpack (5.1.1) lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
activesupport (5.1.1) lib/active_support/notifications.rb:166:in `block in instrument'
activesupport (5.1.1) lib/active_support/notifications/instrumenter.rb:21:in `instrument'
activesupport (5.1.1) lib/active_support/notifications.rb:166:in `instrument'
actionpack (5.1.1) lib/action_controller/metal/instrumentation.rb:30:in `process_action'
actionpack (5.1.1) lib/action_controller/metal/params_wrapper.rb:252:in `process_action'
activerecord (5.1.1) lib/active_record/railties/controller_runtime.rb:22:in `process_action'
actionpack (5.1.1) lib/abstract_controller/base.rb:124:in `process'
actionview (5.1.1) lib/action_view/rendering.rb:30:in `process'
actionpack (5.1.1) lib/action_controller/metal.rb:189:in `dispatch'
actionpack (5.1.1) lib/action_controller/metal.rb:253:in `dispatch'
actionpack (5.1.1) lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
actionpack (5.1.1) lib/action_dispatch/routing/route_set.rb:31:in `serve'
actionpack (5.1.1) lib/action_dispatch/journey/router.rb:46:in `block in serve'
actionpack (5.1.1) lib/action_dispatch/journey/router.rb:33:in `each'
actionpack (5.1.1) lib/action_dispatch/journey/router.rb:33:in `serve'
actionpack (5.1.1) lib/action_dispatch/routing/route_set.rb:832:in `call'
remotipart (1.3.1) lib/remotipart/middleware.rb:32:in `call'
warden (1.2.7) lib/warden/manager.rb:36:in `block in call'
warden (1.2.7) lib/warden/manager.rb:35:in `catch'
warden (1.2.7) lib/warden/manager.rb:35:in `call'
rack (2.0.3) lib/rack/etag.rb:25:in `call'
rack (2.0.3) lib/rack/conditional_get.rb:38:in `call'
rack (2.0.3) lib/rack/head.rb:12:in `call'
rack (2.0.3) lib/rack/session/abstract/id.rb:232:in `context'
rack (2.0.3) lib/rack/session/abstract/id.rb:226:in `call'
actionpack (5.1.1) lib/action_dispatch/middleware/cookies.rb:613:in `call'
activerecord (5.1.1) lib/active_record/migration.rb:556:in `call'
actionpack (5.1.1) lib/action_dispatch/middleware/callbacks.rb:26:in `block in call'
activesupport (5.1.1) lib/active_support/callbacks.rb:97:in `run_callbacks'
actionpack (5.1.1) lib/action_dispatch/middleware/callbacks.rb:24:in `call'
actionpack (5.1.1) lib/action_dispatch/middleware/executor.rb:12:in `call'
actionpack (5.1.1) lib/action_dispatch/middleware/debug_exceptions.rb:59:in `call'
web-console (3.5.1) lib/web_console/middleware.rb:135:in `call_app'
web-console (3.5.1) lib/web_console/middleware.rb:20:in `block in call'
web-console (3.5.1) lib/web_console/middleware.rb:18:in `catch'
web-console (3.5.1) lib/web_console/middleware.rb:18:in `call'
actionpack (5.1.1) lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
railties (5.1.1) lib/rails/rack/logger.rb:36:in `call_app'
railties (5.1.1) lib/rails/rack/logger.rb:24:in `block in call'
activesupport (5.1.1) lib/active_support/tagged_logging.rb:69:in `block in tagged'
activesupport (5.1.1) lib/active_support/tagged_logging.rb:26:in `tagged'
activesupport (5.1.1) lib/active_support/tagged_logging.rb:69:in `tagged'
railties (5.1.1) lib/rails/rack/logger.rb:24:in `call'
sprockets-rails (3.2.0) lib/sprockets/rails/quiet_assets.rb:13:in `call'
actionpack (5.1.1) lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
actionpack (5.1.1) lib/action_dispatch/middleware/request_id.rb:25:in `call'
rack (2.0.3) lib/rack/method_override.rb:22:in `call'
rack (2.0.3) lib/rack/runtime.rb:22:in `call'
activesupport (5.1.1) lib/active_support/cache/strategy/local_cache_middleware.rb:27:in `call'
actionpack (5.1.1) lib/action_dispatch/middleware/executor.rb:12:in `call'
actionpack (5.1.1) lib/action_dispatch/middleware/static.rb:125:in `call'
rack (2.0.3) lib/rack/sendfile.rb:111:in `call'
railties (5.1.1) lib/rails/engine.rb:522:in `call'
puma (3.8.2) lib/puma/configuration.rb:224:in `call'
puma (3.8.2) lib/puma/server.rb:600:in `handle_request'
puma (3.8.2) lib/puma/server.rb:435:in `process_client'
puma (3.8.2) lib/puma/server.rb:299:in `block in run'
puma (3.8.2) lib/puma/thread_pool.rb:120:in `block in spawn_thread'
nandiniverma commented 6 years ago

you must include <%= hidden_field_tag 'authenticity_token', form_authenticity_token %> in your form

mshibuya commented 6 years ago

1.3.1 should work with Rails 5. If there's any issue with Rails 5, please open another issue describing your case.