search

JangoSteve / remotipart

Rails jQuery file uploads via standard Rails "remote: true" forms.
http://os.alfajango.com/remotipart
Other
1k stars 215 forks source link

Version 1.4.1 undefined local variable or method `controller' #195

Closed kntmrkm closed 6 years ago

kntmrkm commented 6 years ago

After update to 1.4.1.

 module RequestHelper
    def remotipart_submitted?
      controller && params[:remotipart_submitted] ? true : false
    end

    alias :remotipart_requested? :remotipart_submitted?

My env?

mshibuya commented 6 years ago

Hmm... 😰 Can you reproduce it using this? https://github.com/kntmrkm/rails51/tree/remotipart

mshibuya commented 6 years ago

Confirmed, yanked 1.4.1 from rubygems.

mshibuya commented 6 years ago

Pushed another fix as eece683d5dfb8b9d0344a706cb4cdfec4248098e, please see if it works and not breaks web-console.

kntmrkm commented 6 years ago

https://github.com/JangoSteve/remotipart/commit/eece683d5dfb8b9d0344a706cb4cdfec4248098e

It work. and not break web-console.

mshibuya commented 6 years ago

Thanks for the help, just published 1.4.2.