search

JangoSteve / remotipart

Rails jQuery file uploads via standard Rails "remote: true" forms.
http://os.alfajango.com/remotipart
Other
1k stars 215 forks source link

Add frozen_string_literal: true magic comment, fix some coding style #199

Closed n-rodriguez closed 5 years ago

n-rodriguez commented 6 years ago

Hi!

This PR adds #frozen_string_literal: true magic comment that freezes literal strings in files. This should help to gain some performance especially in https://github.com/JangoSteve/remotipart/blob/master/lib/remotipart/middleware.rb. I don't know how it's possible but Skylight reports me an average of 55,727 allocations in Remotipart::Middleware. Thank you!

n-rodriguez commented 6 years ago

I don't know how it's possible but Skylight reports me an average of 55,727 allocations in Remotipart::Middleware.

Sorry. I misread the Skylight report. Anyway... it doesn't hurt to gain some performance points :)

n-rodriguez commented 6 years ago

Hi there! Any news?

n-rodriguez commented 5 years ago

Hi there! Any news?

n-rodriguez commented 5 years ago

Hi there! Any news?