search

JangoSteve / remotipart

Rails jQuery file uploads via standard Rails "remote: true" forms.
http://os.alfajango.com/remotipart
Other
1k stars 215 forks source link

Load action_controller lazily #206

Closed arr-dev closed 4 years ago

arr-dev commented 4 years ago

Fixes deprecation notice https://github.com/rails/rails/issues/36546

arr-dev commented 4 years ago

Failures are caused by Sprockets 4, so either manifest.js should be added or sprockets should be downgraded to < 4, not sure what's the preferred option?

vdegove commented 4 years ago

Fixes #207 I had opened the issue without seeing the PR.

vdegove commented 4 years ago

Failures are caused by Sprockets 4, so either manifest.js should be added or sprockets should be downgraded to < 4, not sure what's the preferred option?

@arr-dev it seems the correct way to go is to define assets for precompilation in engine.rb: https://guides.rubyonrails.org/engines.html#separate-assets-precompiling See discussion here: https://github.com/rails/sprockets/issues/415

arr-dev commented 4 years ago

Adding manifest solved these failures, but app still needs to manually require jquery.remotipart, no changes there.

mshibuya commented 4 years ago

Great work, thanks!