nus-pe-bot
commented
1 year ago Team's Response
We chose only to display the main activation bar of each class/method in order to minimize notation so as to keep the diagram simple and easy to understand.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Thank you for the response. The reader refers you to the screenshot below taken from the CS2113 website, that says omission of elements must not result in a loss of "relevant information". That is why the reader did not point out the same missing self-invocation activation bar for UI, because this particular sequence diagram is focusing on the sequence of what happens when the DeleteIncomeCommand was executed, whose missing activation bar for its own method execute() actually results in a loss of relevant information. Now the reader does not know where does execute() finishes running, and who exactly is calling the methods going out of the single activation bar of DeleteIncomeCommand?
Hence the reader appeals to the teaching team to reconsider if this bug should be accepted as reported. Thank you
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** The reader's ability to comprehend how the system works at the deeper level for the DeleteIncomeCommnad was hindered to a considerable extent due to the missing self-invocation activation bar. The reader does not know where does execute() finishes running, and who exactly is calling the methods going out of the single activation bar of DeleteIncomeCommand?
When the DeleteIncomeCommand self-invocates execute(), there should be another activation bar for the execute command.