mbosselmann
commented
8 months ago Hi Team ServiceCircle, good start! 👍 Here are my remarks:
Value Proposition:
- I am a little confused about the part with the "financial data" as currently you do not store these kind of data or? 😅
- I think we can work on make the value proposition more clear to everyone. My suggestion:
As a User, I want to ensure only authenticated user have access to the sensitive data of the application, in order to provide a private and secure experience while using the platform.
My questions: If I did understand correctly there will be some parts that are still visible for users that are not logged in or? If this is not correct anymore, please change the text accordingly. :)
Description/Acceptance criteria: To only see the login itself does not help in understanding how the login will be integrated inside of the app. What will the user see who is not logged in yet. Which parts can the user access? What is the difference after the login? Please provide wireframes which visualize these different use cases. And also your acceptance criteria should be updated to be more specific about the user experience. If you follow the implementation of our workshop then the user won't login via email and password inside of your app buty via a provider like GitHub. So the think you need is only a sign in button. :) See third commit of the next auth workshop repo.
Tasks:
- This task let me think about if you want to change all user specific data in one user story: "Ensure that authenticated users have access to their personalized expense data and settings" 🤔 I would suggest to have one user story for the login feature and that the contact details from each service are shown then and a user story to connect star rating, review and favorites with the user. As this could lead to a lot of code that needs to be changed I would recommend to split this in multiple user stories (also it is really hard to give a good review when you have a huge PR).
I hope this does help! 👋
Value proposition
As a User I want to ensure only authenticated user have access to the sensitive data of the application, in order to provide a private and secure experience while using the platform.
Description
Acceptance Criteria
[ ] The user can see explore the app without creating an account, providing a seamless experience.
[ ] when the user clicks on one of the favorite page, Make a service offer page, access to make Rating or add review to service providers, there is a request message to log in
[ ] The inability to create a service provider, edit his card, delete it, or provide an review or rating unless he is logged in.
Task
[ ] Creating Branch "Login"
[ ] Create a button and login page with authentication
[ ] Create a dedicated Login Page for Github
[ ] conditional render the favorite page, Make a service offer page, the review and access to edit or delete service provider