JankariTech / web-app-presentation-viewer

ownCloud Web extension to view markdown presentation slides
Apache License 2.0
4 stars 1 forks source link

[Bug] Fonts in /assets are not loaded correctly in the web viewer #30

Closed saw-jan closed 6 months ago

saw-jan commented 7 months ago

After building the extension, we get dist/assets with some fonts in it. The extension tries to load the fonts in web without success. The font URLs are not the correct ones.

Screenshot from 2024-02-28 17-39-39

saw-jan commented 7 months ago

Maybe we should wait for https://github.com/owncloud/ocis/pull/8523, then don't have to do anything here

koebel commented 7 months ago

Maybe we should wait for owncloud/ocis#8523, then don't have to do anything here

If you think this the issue mentioned above will fix this problem, I think it's completely fine to wait for this issue to be solved, in particularly also in light that this is not a paid project

saw-jan commented 7 months ago

I was hoping that it would solve but looks like we have to build with some config set to make it work properly

fschade commented 7 months ago

I can check the problem in the app pr, I still have to adjust some details.

saw-jan commented 7 months ago

I can check the problem in the app pr, I still have to adjust some details.

I believe the problem can be fixed while building the extension using vite config. I have tried in PR https://github.com/JankariTech/web-app-presentation-viewer/pull/32 and it works. But I don't know if this can be resolved from app PR.

fschade commented 7 months ago

I can check the problem in the app pr, I still have to adjust some details.

I believe the problem can be fixed while building the extension using vite config. I have tried in PR #32 and it works. But I don't know if this can be resolved from app PR.

i can confirm, the path must be relative to the file that imports the assets 🤗

saw-jan commented 7 months ago

i can confirm, the path must be relative to the file that imports the assets 🤗

Thanks for confirming. :smiley: :heart: