JankariTech / web-app-presentation-viewer

ownCloud Web Presentation Viewer is an extension of ownCloud Web to create and share slide presentations rendered from MD files
Apache License 2.0
4 stars 1 forks source link

feat: use ocis images from same directory level #48

Closed saw-jan closed 1 month ago

saw-jan commented 3 months ago

Description

FEAT: able to use images available at the same directory level as the markdown file in the ocis server.

Requirements:

  1. allow to embed images that are stored in the same folder or its subfolders by using the markdown image syntax

same folder - :heavy_check_mark: subfolders - :x: (Follow up in next PR)

  1. not allowing to embed files from a folder of higher levels

:heavy_check_mark:

  1. require the whole folder be publicly shared if the public viewer should see the images

:heavy_check_mark:

  1. if only the markdown file is publicly share the viewer should not be able to access the images

:heavy_check_mark:

Test Cases:

Related Issue

Screenshots (if appropriate):

Owner: Screenshot from 2024-04-15 12-11-10 Screenshot from 2024-04-15 12-11-04
Folder Link - Viewer: Screenshot from 2024-04-15 12-13-44 Screenshot from 2024-04-15 12-13-52
MD File link - Editor: Screenshot from 2024-04-15 12-18-28 Screenshot from 2024-04-15 12-12-26

Types of changes

Checklist:

saw-jan commented 2 months ago

This PR will be merged to the main branch which will be v2.0.0. We have released v1.0.0

@grgprarup @S-Panta I have updated the comments. Please re-check if it works