JannesMeyer / TabAttack

Advanced Tab management
GNU Affero General Public License v3.0
190 stars 12 forks source link

"Close all tabs" also closes pinned tabs #18

Open voidl opened 9 years ago

voidl commented 9 years ago

Should the "Close all tabs" button also close pinned tabs that weren't imported into TabAttack?

image

JannesMeyer commented 9 years ago

That's quite true! I hadn't thought of that. And it probably shouldn't close tabs that were ignored based on the domain name neither.

A fix for this will definitely make it into the next release. But I'm currently working in a separate branch on the next version which will have Firefox support which is only 50% done so far.

voidl commented 9 years ago

Great! thanks for the awesome extension.

sknebel commented 9 years ago

@JannesMeyer are patches to the current version of the extension likely to be portable to the new one, or should I wait until the version with firefox support is out? (I have a few ideas for stuff to add, but nothing that needs to be added ASAP)