search

JannesMeyer / TabAttack

Advanced Tab management
GNU Affero General Public License v3.0
190 stars 12 forks source link

Use smaller font size in icon for large tab counts #6

Closed sknebel closed 9 years ago

sknebel commented 9 years ago

Hi,

this commit fixes tab count display for 3-digit tab counts. Since dynamically modifying text size in Canvas is kind of a pain and I haven't heard of any users able to run Chrome with >999 tabs I decided to only add a fixed smaller text size for numbers with more than 2 digits. Until #3 is fixed this can only guess what a suitable font size is.

Result (before left, after right) image

sknebel commented 9 years ago

Just learned that the "default" way to display such a number would be to use a "badge". We could change to that alternatively.

JannesMeyer commented 9 years ago

Hi sknebel,

263 tabs! Respect! I simply didn't consider that anyone could operate Chrome sanely with a three-digit tab count ;-) (I only have 4 GB of ram on my laptop)

The pull request looks great. Merging. Thanks a lot! Hopefully I can push v0.13 out tonight.

Just learned that the "default" way to display such a number would be to use a "badge". We could change to that alternatively.

Yep, I know about chrome.browserAction.setBadgeText. I was actually using that API in an earlier version of the extension (before I open sourced it), but I didn't like it that much, because the numbers were pretty small and the rest of the icon was occupied by the rather useless extension icon. I also quite like the analogy of the rendered icon to the Android and iOS versions of Chrome.