JannikHv / gydl

gydl (Graphical YouTube-Download) is a GUI wrapper around yt-dlp.
GNU General Public License v2.0
151 stars 22 forks source link

Missing documentation about audio quality #16

Closed nottux closed 5 years ago

nottux commented 6 years ago

screenshot what does the quality level do? (like what is the specific quality selection at each level and is it 0 or 9 is the best quality?)

audio_samples.zip

files in it: work0.mp3 --> audio sample with option 0 chosen work1.mp3 --> audio sample with option 1 chosen work9.mp3 --> audio sample with option 9 chosen

as i look to codec information audio quality and size comparison was 0>1>9

[utku@utku ~]$ uname -a
Linux utku 4.15.3-2-ARCH #1 SMP PREEMPT Thu Feb 15 00:13:49 UTC 2018 x86_64 GNU/Linux

Antergos installation with xfce desktop, 64 bit

JannikHv commented 6 years ago

Going to add this to the README soon, thanks for bringing this to my attention.

Marking this as solved as soon as I did so.

p3732 commented 5 years ago

I think just putting it in the README will not help much for people simply using gydl (and not compiling it themselves).

How about renaming the dropdown menu items to "0 (Best)", 1, 2, 3, 4, 5 (Average), 6, 7, 8, 9 (Smallest). Also I would assume it's a good idea to default to 0.

p3732 commented 5 years ago

I was wondering how to get the strings translated, but then I saw that the other strings in gydl.py are not translatable either and that there is a C rewrite available. Hope this is still fine :)

JannikHv commented 5 years ago

Thanks for the pull request! I'll later adopt the changes in the C-Rewrite.