JannisX11 / blockbench

Blockbench - A low poly 3D model editor
https://www.blockbench.net
GNU General Public License v3.0
3.13k stars 277 forks source link

Graph mode vertical scroll bar can have infinite overflow #2116

Closed Cub0use closed 7 months ago

Cub0use commented 7 months ago

What are you trying to do, and what do you expect to happen?

Editing keyframes with the graph editor.

What happens instead?

The problem seems similar to https://github.com/JannisX11/blockbench/issues/2113, or could be caused by it.

When the timeline view is far enough to the right (zoom amount has no play in it) and the Animators list becomes offset like shown in https://github.com/JannisX11/blockbench/issues/2113; the vertical bar thumb shows, with more track space depending on the difference in value of keyframes around 0. Dragging or scrolling it cuts off the curves and the Animators list.

The scroll bar thumb actually always appears in graph mode, even when there is enough vertical space in the timeline tab for all the Animators that are brought up (or no animators at all even). Since the graph view scales vertically to fit the curves, shouldn't the scroll bar thumb only depend on the list of Animators? I'm guessing it could be there for practical coding reasons.

https://github.com/JannisX11/blockbench/assets/81629481/8accc169-5f07-45e3-ab69-97de72c85098

Model format in which the issue occurs

All those with keyframe animation

Blockbench variant

Program

Blockbench version

4.9.0 Beta 2

Operating System

W10

Installed Blockbench plugins

N/A