JannisX11 / blockbench

Blockbench - A low poly 3D model editor
https://www.blockbench.net
GNU General Public License v3.0
3.3k stars 286 forks source link

Flip Animation is inexact when keyframes don't fit Snapping #2151

Open Cub0use opened 9 months ago

Cub0use commented 9 months ago

What are you trying to do, and what do you expect to happen?

Using Flip Animation to copy and offset keyframes to a symmetrical group.

What happens instead?

-The starting/ending keyframes are doubled at 1 step offset from one another.

-There should be a created keyframe at the end of the flipped channel, the same as at timestamp 0 (when there isn't an original one at exactly half the animation length)

-the keyframes in the middle of the animation are not placed precisely at + half the animation length (because they respect the animation's Snapping value).

https://github.com/JannisX11/blockbench/assets/81629481/086e1573-821f-4403-8e1e-66ddec772b9f

When I double the snapping to 50, the flipped keyframes can get a timestamp offset by exactly half the animation length, and the issue is not present.

I understand that flipping the keyframes will still be an approximation of the originals when offsetting them, but the two first points are bug material to me.

Perhaps there should be a tick box in the flip animation tool dialog to double the snapping value, if needed?

Model format in which the issue occurs

Bedrock Entity

Blockbench variant

Program

Blockbench version

4.9.1

Operating System

W10

Installed Blockbench plugins

N/A