search

JannisX11 / blockbench

Blockbench - A low poly 3D model editor
https://www.blockbench.net
GNU General Public License v3.0
3.07k stars 272 forks source link

add arm64 and armv7l arches to linux CI #2187

Open theofficialgman opened 5 months ago

theofficialgman commented 5 months ago

Known issues: 3rd party library is 4+ years unmaintained and does not have ARM64 or ARMhf scrot native binaries on linux https://www.npmjs.com/package/electron-color-picker

electron-color-picker should be moved away from anyway as it is not wayland compatible which is the current default window system on linux desktops in 2024

you will likely want to move to gcolor3 as it seems to work well for me on wayland and x11 due to using the xdg desktop portals for obtaining color information https://www.hjdskes.nl/projects/gcolor3/

I am not actually sure what this library is being used for in blockbench as the "pick screen color" option in the paint section does work on ARM64 xorg linux in testing but not in wayland on any architecture.

theofficialgman commented 4 months ago

@JannisX11 thoughts? I would have expected some response by now.

txtsd commented 2 months ago

@JannisX11 Getting rid of electron-color-picker is an excellent idea. Please let us know what kind of feedback you need. There are a lot of Linux users here.