search

JannisX11 / blockbench

Blockbench - A low poly 3D model editor
https://www.blockbench.net
GNU General Public License v3.0
3.06k stars 272 forks source link

[BUG] Exported models with GLTF / GLB broke the animations. #2204

Closed MrScautHD closed 1 month ago

MrScautHD commented 4 months ago

What are you trying to do, and what do you expect to happen?

Loading the model into model viewers, and played the animations. (like this: https://sandbox.babylonjs.com/)

What happens instead?

But the model starts to brake:

Instead of: grafik

It looks like this: image-1

Model format in which the issue occurs

GLTF / GLB

Blockbench variant

Website, Program

Blockbench version

4.9.4

Operating System

Windows 11

Installed Blockbench plugins

No response

MrScautHD commented 4 months ago

@JannisX11 already fixed?

MrScautHD commented 3 months ago

It looks like the animations get mixed

JannisX11 commented 2 months ago

Could you test if this is still an issue in the 4.10 beta? https://github.com/JannisX11/blockbench/releases/tag/v4.10.0-beta.1

MrScautHD commented 2 months ago

Could you test if this is still an issue in the 4.10 beta? https://github.com/JannisX11/blockbench/releases/tag/v4.10.0-beta.1

Still broken :(

MrScautHD commented 1 month ago

@JannisX11 is it still an issue?

JannisX11 commented 1 month ago

I am not sure, I have tested a few models during beta and haven't run into the issue since. If you can still reproduce it, please share the model and configuration so that I can recreate it on my end.

MrScautHD commented 1 month ago

@JannisX11 Here is a model build with the latest Blockbench version: Player-Female-new.zip grafik

MrScautHD commented 1 month ago

And here are the arms up grafik

it looks like the animation blending in one.

That is how it should looks like: grafik

JannisX11 commented 1 month ago

Could you share the bbmodel file with the export configuration of an affected model so that I can try and reproduce it?

MrScautHD commented 1 month ago

@JannisX11 Player-Female.zip

MrScautHD commented 1 month ago

@JannisX11 do you found the error?

JannisX11 commented 1 month ago

Yup, it happens because the arm bones have a 90 degree angle in edit mode. The armature animation doesn't handle that correctly. I'm working on a fix.

MrScautHD commented 1 month ago

@JannisX11 And what about the mixing of the Animations i mean in idle the hands move upwards, the feed is rotated wierd... Should that get fixed too?

JannisX11 commented 1 month ago

Fixed 🎉

glitch128 commented 1 month ago

has the site been updated yet? edit: saw that it was pushed to patch, so no. the site hasn't been updated yet

MrScautHD commented 1 month ago

@JannisX11

Amazing work, thx. But there a still some small issues

If you see one shoe is a bit more rotated down as the other one grafik

But in blockbench it works fine: grafik

Even for the arms: grafik

In blcokbench: grafik

But it looks like this happans when seting a diffrent animation like from walk to idle the hands working fine but by moving from run to idle the hands breaks. (Like the old pos of the animations not reset just get overriden)

MrScautHD commented 1 month ago

But i see right now the issue comes from (https://sandbox.babylonjs.com/)

Because with the windows model viewer it works fine. grafik

glitch128 commented 1 month ago

looks fine on https://glb.ee/ as well. maybe it's just a thing with babylon