JannisX11 / blockbench

Blockbench - A low poly 3D model editor
https://www.blockbench.net
GNU General Public License v3.0
3.06k stars 271 forks source link

Improve in-editor gif recording functionality and performance for non-desktop users #2262

Open lunahhhhhhhhhhhhhhhh opened 2 months ago

lunahhhhhhhhhhhhhhhh commented 2 months ago

Detailed description of your suggestion

I have noticed some functionality that might be great to add to the in-editor gif recording for those that can't use the ffmpeg-based plugin (web/mobile users);

lunahhhhhhhhhhhhhhhh commented 2 months ago

My own qualms with the current feature are that black areas of a background image go transparent which I attempted to fix here https://github.com/JannisX11/blockbench/pull/2259 but also I get flickering in the background image of a gif which I assume is from the algorithim to reduce the color palette as playing with the format/encoding function in screenshot.js didn't help much

JannisX11 commented 2 months ago

The format is a good catch, I used rgba4444 because I thought it was the only one with alpha support, but it's just the added alpha channel and the other formats work with 1 bit alpha as well. Switched to rgb565 as the default now since alpha channels aren't fully supported either way.

lunahhhhhhhhhhhhhhhh commented 2 months ago

Options I have found for making the frames of the animation gif-ready:

Both of these options don't seem to work with gifenc so it may need to be paired with omggif