JannisX11 / blockbench

Blockbench - A low poly 3D model editor
https://www.blockbench.net
GNU General Public License v3.0
3.06k stars 271 forks source link

Crash when saving something using "Save Project As" a second time. (Linux Mint) #2263

Open aaronGlawson64 opened 2 months ago

aaronGlawson64 commented 2 months ago

What are you trying to do, and what do you expect to happen?

I'm trying to save a generic model with "Save Project As".

What happens instead?

the program crashes with the error "APPIMAGE env is not defined, current application is not an appImage". It happens when I save two different things, and it happens when saving the same thing twice. I can restart the program, and pick up where I saved the first time, but if I want to make progress and save my changes I have to restart the program before I change anything to ensure it doesn't crash when I go to save it.

Model format in which the issue occurs

Generic Model

Blockbench variant

Program

Blockbench version

4.9.4

Operating System

Linux Mint

Installed Blockbench plugins

None

aaronGlawson64 commented 2 months ago

More info: The crash happens whether I make changes to the file or not. The crash doesn't happen when I use "Save Project". It only happens when I use "Save Project as" twice in one session. It does not matter if I'm saving the same file, or a different one.

JannisX11 commented 1 month ago

Which installer or package manager did you use? Could you try with a different one and see if the issue persists?

Stella-Zephyr commented 1 month ago

I would like to add to this conversation, since I have come upon a scenario similar enough that making another issue for it would be an inconvenience.

Since I'm using Arch Linux's AUR, which is not officially supported, I will not include my experience from that execution of the program. However, since the bug also presented itself when I reinstalled via Flatpak, I believe it is worth mentioning.

What are you trying to do, and what do you expect to happen?

I attempted to use the Save As... prompt in my system to attempt to save a project. Happens with new projects and when saving old projects via the Save Project As... prompt. Expected the program to save the project and resume normal function.

What happens instead?

Once the Save As... prompt from the system closes, the program becomes completely unresponsive. Only viable action is to force close the program via the Window Manager's kill process method (e.g. Alt+F4 on KDE Plasma). The file is not saved, but it is preserved with the Backups function.

Model format in which the issue occurs

Seemingly any format.

Blockbench variant

Program

Blockbench version

4.10.1-1

Operating System

Arch Linux (tested with AUR script and official Flatpak release)

Installed Blockbench plugins

None.

Please inform me if this is bad form and I should make a different issue for this, I am unsure as to how to contribute and want to be as helpful as possible.

4194304 commented 1 week ago

I can report this on Arch Linux, occurs on Wayland for me with another issue I reported. This one is quite the annoyance since every time I use Blockbench, I'll have to use X11 (logging out and logging back in again isn't exactly something I want to do every time I want to use Blockbench).

Raft08 commented 1 week ago

Hey, got the same issue with but just after closing the file picker, even if no file is selected it crashes. Also for the exporting the model.

It freezes until I force-quit. I'm using Arch linux with Hyprland (XWayland) as desktop environment.

Nothing is shown in the console when running blockbench from the terminal.

Raiguri commented 1 week ago

Can confirm same issue with aur package, but if I use flatpak everything is okay.

System info: arch, wayland, gnome, nvidia

JannisX11 commented 4 days ago

All comments refer to a different issue, which is tracked here: #2364 That issue has since been fixed in versions from the official website, and I'm working on a fix that applies to third party builds as well.

The issue here is unrelated, since it happened before, and it requires saving twice. I was unable to reproduce the issue so far. Tested on KDE neon 5.27.

AlexTMjugador commented 4 days ago

[...] That issue has since been fixed in versions from the official website, and I'm working on a fix that applies to third party builds as well.

Just my two cents here: if the issue is fixed by pinning Electron to version 30.0.3 as it was done on https://github.com/JannisX11/blockbench/commit/bdf00433647bc24a2d74c8aadbcb673001c57bee, what's stopping us from changing the package.json and package-lock.json files to pin the project to that known-good version? Do other platforms require newer Electron features or fixes? I've skimmed through the Electron 30.x series changelog and didn't see any changes that struck to me as particularly necessary.

4194304 commented 3 days ago

it appears as if the crash only occurs on GNOME's Wayland session with Nvidia drivers