JannisX11 / blockbench

Blockbench - A low poly 3D model editor
https://www.blockbench.net
GNU General Public License v3.0
3.05k stars 271 forks source link

Added "solid with marker color" view mode from #2316 #2331

Closed Azagwen closed 1 month ago

Azagwen commented 1 month ago

This pull request adds the view mode requested in #2316 At the moment localization seems to not be working (on my end only ?), even tho I have added entries in the lang files of which I speak the language, I haven't managed to find why.

What I did here is basically duplicate the "solid" view mode and its associated canvas & preview setup, but with an added marker color component, just like the default "texture" view mode already has

Demo Video (recorded on the netify preview to have working localization)

https://github.com/JannisX11/blockbench/assets/30528331/bd0afeed-e299-4e0b-af7f-1a69707d3933

netlify[bot] commented 1 month ago

Deploy Preview for blockbench-dev ready!

Name Link
Latest commit a565e7209f2d260fa445dde36ae8daa8701e9ff0
Latest deploy log https://app.netlify.com/sites/blockbench-dev/deploys/66410066db2d6300080ba86c
Deploy Preview https://deploy-preview-2331--blockbench-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JannisX11 commented 1 month ago

You should only add localized strings to the english language file, all other languages are handled by the POEditor project. After adding translations, you can run npm run bundle to build it locally and properly see those translations.

Azagwen commented 1 month ago

You should only add localized strings to the english language file, all other languages are handled by the POEditor project. After adding translations, you can run npm run bundle to build it locally and properly see those translations.

Oh! Okay, that makes sense, I'll remove the other translation I had added then And running that did work, good to know 😄

Azagwen commented 1 month ago

I just tested with the custom Marker Color plugin, Canvas freezes and spits errors 🥲 Will investigate

EDIT: Fixed it