Jannomag / Yaru-Colors

A fork of Ubuntu's Yaru theme - in different colors
GNU General Public License v3.0
512 stars 42 forks source link

Red squares instead of radio and checkboxes #54

Closed VentGrey closed 4 years ago

VentGrey commented 4 years ago

Edit: Possible duplicate of #51 Edit II: Also tried downloading the release tar, can confirm it happens here as well.

Using latest packed yaru-colors. This bug affects: blue, red and purple variants (haven't tried others). image As you can see, "checked" boxes show only a red square instead of a full checkmark with the correct color variant. However unlike the #51 issue, I've downloaded the themes from gnome-look.org site since the install script breaks a non-ubuntu system (namely funtoo).

Jannomag commented 4 years ago

First, a question: how does my script break non-ubuntu distros? Second: Currently I'm not able to work on Yaru-Colors because I don't have much free time at the moment. I'll take a look over the files when I have the time and reply to this issue. Please leave it open.

EDIT: So, I've found some time to check it out. I did following:

I can't reproduce this issue, every theme worked well. See the screenshots: Bildschirmfoto von 2020-09-01 14-35-00 Bildschirmfoto von 2020-09-01 14-35-10 Bildschirmfoto von 2020-09-01 14-35-54

Currently, I'm downloading Funtoo (5.1beta iso) and try it in a VM. I'll edit this post later

EDIT 2: After looking for Funtoo, I decided to try it with Manjaro and Fedora, both latest versions and both with Gnome 3.36.5. (Funtoo was way to complicated to install for me...) Yaru-Colors worked without any issues on both distros.

So, the issue seems to be on your side. Please check if following files are present:

.
├── gtk-3.0    
│   └── assets    
│       ├── checkbox-active-selectionmode@2.png    
│       ├── checkbox-active-selectionmode.png    
│       ├── checkbox-backdrop-selectionmode@2.png    
│       ├── checkbox-backdrop-selectionmode.png    
│       ├── checkbox-checked@2.png    
│       ├── checkbox-checked-active@2.png    
│       ├── checkbox-checked-active.png    
│       ├── checkbox-checked-active-selectionmode@2.png    
│       ├── checkbox-checked-active-selectionmode.png    
│       ├── checkbox-checked-backdrop@2.png    
│       ├── checkbox-checked-backdrop-insensitive@2.png    
│       ├── checkbox-checked-backdrop-insensitive.png    
│       ├── checkbox-checked-backdrop.png    
│       ├── checkbox-checked-backdrop-selectionmode@2.png    
│       ├── checkbox-checked-backdrop-selectionmode.png    
│       ├── checkbox-checked-hover@2.png    
│       ├── checkbox-checked-hover.png    
│       ├── checkbox-checked-hover-selectionmode@2.png    
│       ├── checkbox-checked-hover-selectionmode.png    
│       ├── checkbox-checked-insensitive@2.png    
│       ├── checkbox-checked-insensitive.png    
│       ├── checkbox-checked.png    
│       ├── checkbox-checked-selectionmode@2.png    
│       ├── checkbox-checked-selectionmode.png    
│       ├── checkbox-hover-selectionmode@2.png    
│       ├── checkbox-hover-selectionmode.png    
│       ├── checkbox-mixed@2.png    
│       ├── checkbox-mixed-active@2.png    
│       ├── checkbox-mixed-active.png    
│       ├── checkbox-mixed-backdrop@2.png    
│       ├── checkbox-mixed-backdrop-insensitive@2.png    
│       ├── checkbox-mixed-backdrop-insensitive.png    
│       ├── checkbox-mixed-backdrop.png    
│       ├── checkbox-mixed-hover@2.png    
│       ├── checkbox-mixed-hover.png    
│       ├── checkbox-mixed-insensitive@2.png    
│       ├── checkbox-mixed-insensitive.png    
│       ├── checkbox-mixed.png    
│       ├── checkbox-selectionmode@2.png    
│       ├── checkbox-selectionmode.png    
│       ├── checkbox-unchecked@2.png    
│       ├── checkbox-unchecked-active@2.png    
│       ├── checkbox-unchecked-active.png    
│       ├── checkbox-unchecked-backdrop@2.png    
│       ├── checkbox-unchecked-backdrop-insensitive@2.png    
│       ├── checkbox-unchecked-backdrop-insensitive.png    
│       ├── checkbox-unchecked-backdrop.png    
│       ├── checkbox-unchecked-hover@2.png    
│       ├── checkbox-unchecked-hover.png    
│       ├── checkbox-unchecked-insensitive@2.png    
│       ├── checkbox-unchecked-insensitive.png    
│       └── checkbox-unchecked.png    

Then check the gnome version. Since the latest Yaru-Colors is based on Ubuntu 20.04 Yaru theme, it's made for 3.36.2+.

VentGrey commented 4 years ago

I managed to solve the issue by replicating your advice at #51. Which involves installing Yaru-Purple and not Yaru-Purple-dark alone. The script itself removes (or removed) some symlinks under /usr/share/icons. Under some circunstances in Funtoo this will cause the themes to search for a non existent icon/cursor and segfault some apps.

Old pastebin: https://pastebin.com/7mGxZ1AS :thinking:

PS: I made sure that the files were there and even gave them correct permissions :3 thanks for your reply.

Jannomag commented 4 years ago

Glad it works now. It's mandatory to have the complete theme, just like most other themes.

The missing icon symlinks should not cause errors but I don't know how it works exactly. I added Yaru and Humanity as Inherit theme in the index.theme file. So, the OS / Desktop Environment should inherit to one of those and since Humanity is the stock Gnome icon theme, it should not produce errors if it's present on your system. Funtoo seems to be highly configurable Distro, please be sure to have Humanity, or even better, Yaru, installed.

VentGrey commented 4 years ago

Managed to fix it by installing Humanity and Yaru. I think the symlink removal was the one who made things go kaput.

:thinking: This seemed to be an isolated case. Thanks a lot for your support! :heart:

Jannomag commented 4 years ago

No problem. You also could've edit the index.theme file and add your own icon pack as Inherit theme.