search

Jannyboy11 / InvSee-plus-plus

A bukkit plugin for manipulating player inventories
Other
92 stars 18 forks source link

Spigot 1.21 + Invsee++ #110

Closed jurohn closed 5 months ago

jurohn commented 5 months ago

image Whatever i try, this is the awnser.

jurohn commented 5 months ago

16.06 20:04:06 [Server] Server thread/[ERROR] Error occurred while enabling InvSeePlusPlus v0.28.0 (Is it up to date?) 16.06 20:04:06 [Server] [INFO] java.lang.IncompatibleClassChangeError: class com.janboerman.invsee.spigot.api.SpectatorInventoryView has interface org.bukkit.inventory.InventoryView as super class 16.06 20:04:06 [Server] [INFO] at java.base/java.lang.ClassLoader.defineClass1(Native Method) ~[?:?] 16.06 20:04:06 [Server] [INFO] at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) ~[?:?] 16.06 20:04:06 [Server] [INFO] at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) ~[?:?] 16.06 20:04:06 [Server] [INFO] at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:206) ~[spigot-api-1.21-R0.1-SNAPSHOT.jar:?] 16.06 20:04:06 [Server] [INFO] at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593) ~[?:?] 16.06 20:04:06 [Server] [INFO] at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:117) ~[spigot-api-1.21-R0.1-SNAPSHOT.jar:?] 16.06 20:04:06 [Server] [INFO] at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:112) ~[spigot-api-1.21-R0.1-SNAPSHOT.jar:?] 16.06 20:04:06 [Server] [INFO] at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[?:?] 16.06 20:04:06 [Server] [INFO] at com.janboerman.invsee.spigot.Impl_1_21.(Setup.java:105) ~[?:?] 16.06 20:04:06 [Server] [INFO] at com.janboerman.invsee.spigot.SetupImpl.lambda$static$9(Setup.java:130) ~[?:?] 16.06 20:04:06 [Server] [INFO] at com.janboerman.invsee.spigot.Setup.setup(Setup.java:40) ~[?:?] 16.06 20:04:06 [Server] [INFO] at com.janboerman.invsee.spigot.InvseePlusPlus.onEnable(InvseePlusPlus.java:82) ~[?:?] 16.06 20:04:06 [Server] [INFO] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:267) ~[spigot-api-1.21-R0.1-SNAPSHOT.jar:?] 16.06 20:04:06 [Server] [INFO] at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:342) ~[spigot-api-1.21-R0.1-SNAPSHOT.jar:?] 16.06 20:04:06 [Server] [INFO] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:492) ~[spigot-api-1.21-R0.1-SNAPSHOT.jar:?] 16.06 20:04:06 [Server] [INFO] at org.bukkit.craftbukkit.v1_21_R1.CraftServer.enablePlugin(CraftServer.java:567) ~[spigot-1.21-R0.1-SNAPSHOT.jar:4217-Spigot-146439e-68603b1] 16.06 20:04:06 [Server] [INFO] at org.bukkit.craftbukkit.v1_21_R1.CraftServer.enablePlugins(CraftServer.java:481) ~[spigot-1.21-R0.1-SNAPSHOT.jar:4217-Spigot-146439e-68603b1] 16.06 20:04:06 [Server] [INFO] at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:641) ~[spigot-1.21-R0.1-SNAPSHOT.jar:4217-Spigot-146439e-68603b1] 16.06 20:04:06 [Server] [INFO] at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:426) ~[spigot-1.21-R0.1-SNAPSHOT.jar:4217-Spigot-146439e-68603b1] 16.06 20:04:06 [Server] [INFO] at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:269) ~[spigot-1.21-R0.1-SNAPSHOT.jar:4217-Spigot-146439e-68603b1] 16.06 20:04:06 [Server] [INFO] at net.minecraft.server.MinecraftServer.y(MinecraftServer.java:1017) ~[spigot-1.21-R0.1-SNAPSHOT.jar:4217-Spigot-146439e-68603b1] 16.06 20:04:06 [Server] [INFO] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:318) ~[spigot-1.21-R0.1-SNAPSHOT.jar:4217-Spigot-146439e-68603b1] 16.06 20:04:06 [Server] [INFO] at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]

Jannyboy11 commented 5 months ago

Looks like Spigot broke their api incompatibly. I will try to land a fix tomorrow. This is the change that caused the problem: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/2b4b6d14241d3d96eb6b7d1888176146dc5895d4#src%2Fmain%2Fjava%2Forg%2Fbukkit%2Finventory%2FInventoryView.java

Jannyboy11 commented 5 months ago

There is a PR that fixes compatibility again in CraftBukkit; https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/pull-requests/1425/overview

I will have to update my plugin later because this PR only fixes binary compatibility, not source-compatibility; but at least when this lands users should be able to run the plugin fine again.

I will keep this issue open until InvSee++ is also updated so others can compile it again.

Jannyboy11 commented 5 months ago

Managed to bump out a quick release: https://github.com/Jannyboy11/InvSee-plus-plus/releases/tag/v0.29.0 I haven't tested it myself yet, but it should be good to go.

Note that if you use other plugins which hook into InvSee++, those might be broken currently.

Jannyboy11 commented 5 months ago

Managed to bump out a quick release: https://github.com/Jannyboy11/InvSee-plus-plus/releases/tag/v0.29.0 I haven't tested it myself yet, but it should be good to go.

Note that if you use other plugins which hook into InvSee++, those might be broken currently.

I tested this release today and it works fine.