Jannyboy11 / InvSee-plus-plus

A bukkit plugin for manipulating player inventories
Other
90 stars 16 forks source link

Extra Permission for viewing/editing offline players inventories #126

Open 0x484 opened 1 month ago

0x484 commented 1 month ago

I really love the offline feature of this plugin but do not want everyone to give access to viewing/editing all offline players inventories. This is why I suggest the addition of 2 new permissions to be able to disable this for certain players.

Format could be something like this:

I don't personally use the "players who have never logged into" Feature but I guess this could also be useful for people that want a permission for that as well:

Jannyboy11 commented 1 month ago

Why do you think it's fine for your moderators to edit any online player's inventory, but not any offline player's inventory? They way I see it, both permissions are equally powerful - only in one case they have to be online at the same time of such player.

0x484 commented 1 month ago

Well for safety reasons, tho you should obviously only have trusted people as moderators it doesn't mean you should give them the power to do everything. I think theres a big difference between only being able edit online peoples inventories and literally being able to edit any inventory of any player that has ever been online.

Someone in a Moderator Position does need to view and edit other peoples inventories in order to help or check them for anything wrong. But they don't need the permissions of an admin to do this with all offline players. This would be similar to giving them access to the Playerdata files which they just don't need to be able to.

I don't think such a permission would do anything bad and just be an improvement for the plugin.

Jannyboy11 commented 1 month ago

Okay, I accept your suggestion. For compatibility reasons, I will either split existig permissions into an offline variant variant and online variant, or I will introduce a negative permission instead.

0x484 commented 1 month ago

thank you very much^^