search

Jannyboy11 / InvSee-plus-plus

A bukkit plugin for manipulating player inventories
Other
91 stars 18 forks source link

CI builds are broken #67

Closed Jannyboy11 closed 1 year ago

Jannyboy11 commented 1 year ago

The modules for CraftBukkit-1.20 currently don't build in CI because the CraftBukkit-1.20 server dependency could not be found: https://github.com/Jannyboy11/InvSee-plus-plus/actions/runs/5249196414. This is because running BuildTools with --rev 1.20 actually builds CraftBukkit 1.20.1: https://hub.spigotmc.org/jira/browse/BUILDTOOLS-658. md_5 closed this as a wontfix, so until support for CraftBukkit 1.20 will be dropped, this remains an issue. One way to remedy this would be to build CraftBukkit without BuildTools: just clone the repo, revert to the latest 1.20 commit, apply the nms patches and compile and install. Another option is to just wait and hope that most of my users will migrate to 1.20.1 soon so that I don't have to maintain 1.20 support anymore. Addressing this as wontfix for now.

Jannyboy11 commented 1 year ago

Should be fixed as of https://github.com/Jannyboy11/InvSee-plus-plus/commit/a4673523ac9b0b15e6e065e5b3c5c32e013338f9 by using the undocumented feature of BuildTools that allows you to specify build numbers as the revision.