search

Janrupf / mod-director

Automated mod downloading
https://www.curseforge.com/minecraft/mc-mods/moddirector
MIT License
13 stars 13 forks source link

server crashes when running the mod #9

Closed HansWasser closed 4 years ago

HansWasser commented 4 years ago

I just tried out if the mod would also work on a server, as with the upcomming feature of live modpack updating it'd be a pain for any server admin if the clients update themselves without the server doing so too. Turns out it doesn't work... Here's the log file latest.log

TigerWalts commented 4 years ago

I don't know which mod the tkkl.url.json is supposed to be downloading but it may not be server compatible and this is causing the crash when ModDirector tries to load it.

Had the same problem with the Awakening - Sky of Diamonds pack as it tries to load Optifine.

It would be beneficial for ModDirector to support a side option, with values BOTH, CLIENT, SERVER. e.g.

{
    "url": "http://optifine.net/adloadx?f=OptiFine_1.12.2_HD_U_F5.jar",
    "follows": ["Download OptiFine_1.12.2_HD_U_F5.jar"],
    "fileName": "Optifine_1.12.2_HD_U_F5.jar",
    "options": {
        "launchwrapperTweakerForceNext": true,
        "side": "CLIENT"
    }
}

This way the same configs can be placed on server and client.

HansWasser commented 4 years ago

The mod that's supposed to be downloaded is server compatible. To be fair it is not compatible with the minecraft version the server is running but the server crashes before anything is downloaded. If the server crashed due to an incompatibility with the mod it would have to be downloaded in the first place.

Janrupf commented 4 years ago

I don't know which mod the tkkl.url.json is supposed to be downloading but it may not be server compatible and this is causing the crash when ModDirector tries to load it.

Had the same problem with the Awakening - Sky of Diamonds pack as it tries to load Optifine.

It would be beneficial for ModDirector to support a side option, with values BOTH, CLIENT, SERVER. e.g.

{
    "url": "http://optifine.net/adloadx?f=OptiFine_1.12.2_HD_U_F5.jar",
    "follows": ["Download OptiFine_1.12.2_HD_U_F5.jar"],
    "fileName": "Optifine_1.12.2_HD_U_F5.jar",
    "options": {
        "launchwrapperTweakerForceNext": true,
        "side": "CLIENT"
    }
}

This way the same configs can be placed on server and client.

I like the idea with the "side" config

Janrupf commented 4 years ago

https://github.com/Janrupf/mod-director/wiki/Metadata#side-config