JanssenProject / jans

An open source enterprise digital identity platform for CIAM or workforce... Janssen is a distribution of standards-based, developer friendly, components that are engineered to work together in any cloud. #OAuth #OpenID #FIDO
https://docs.jans.io
Apache License 2.0
472 stars 75 forks source link

feat(agama): prefix log statements generated by Agama flows with the qualified name #5201

Closed jgomer2001 closed 4 months ago

jgomer2001 commented 1 year ago

add any comment you may have @moabu

moabu commented 1 year ago

The usecase here is to be able to filter out logs based on the agama flow. This is especially useful when the IDP is shared and showing logs become a security concern

jgomer2001 commented 1 year ago

I think it is not very useful to filter log statements by flow name in a shared environment because:

nynymike commented 1 year ago

In the shared environment, we are automatically prefixing the QN with the user's github id. As this is an ephemeral enviornment, the only scripts they test will be their own.

jgomer2001 commented 1 year ago

@moabu Messages logged via the Log statements are now prefixed with |flow qname| in AS script log. Example:

|me.gluu.basic_authn| Hello world

Besides jans-auth war update, existing flows need to be redeployed for the change to take effect