search

JanssenProject / jans

An open source enterprise digital identity platform for CIAM or workforce... Janssen is a distribution of standards-based, developer friendly, components that are engineered to work together in any cloud. #OAuth #OpenID #FIDO
https://docs.jans.io
Apache License 2.0
459 stars 73 forks source link

Openbanking - DCR Response code should be 201 for POST /register #568

Closed maduvena closed 3 years ago

maduvena commented 3 years ago

Currently 200 is returned.

maduvena commented 3 years ago

code pushed in jans-auth-server - https://github.com/JanssenProject/jans-auth-server/commit/e855f997ce3028def29d7806bd83ce1f21bcac4a

yuriyz commented 3 years ago

@maduvena it's wrong. You send 201 for client update. I guess it should return 201 for creation only. For update it should be 200.

yuriyz commented 3 years ago

Also it's not clear why ticket in in jans-cli if it seems to be about jans-auth-server. Transfering it to jans-auth-server.

yuriyz commented 3 years ago

Reverted https://github.com/JanssenProject/jans-auth-server/commit/e855f997ce3028def29d7806bd83ce1f21bcac4a and pushed https://github.com/JanssenProject/jans-auth-server/commit/1c5ba6c7169c126d48291c7af0f3f4339e535d49

201 for creation and 200 for update.