JanssenProject / jans

An open source enterprise digital identity platform for CIAM or workforce... Janssen is a distribution of standards-based, developer friendly, components that are engineered to work together in any cloud. #OAuth #OpenID #FIDO
https://docs.jans.io
Apache License 2.0
455 stars 73 forks source link

fix (jans-configapi ) : Not able to create identity provider in Jans-KC. #7972

Closed MohitMaliFtechiz closed 6 months ago

MohitMaliFtechiz commented 6 months ago

Describe the bug Not able to create identity provider in Jans-KC

To Reproduce Steps to reproduce the behavior:

  1. install jan 1.1.0 nightly
  2. Go to jans TUI
  3. Go to jans-saml
  4. Go to identity provider
  5. Create the identity provider and save the details
  6. See error

Expected behavior update IDP should be without error and idp name should be readonly once idp get created like in KC

Screenshots If applicable, add screenshots to help explain your problem. Screenshot (252)

Desktop (please complete the following information):

Additional context Jans-configapi log :

06-03 06:54:10.458 ERROR plugin.saml.service.KeycloakService KeycloakService.java:334- JSONException for attribute:postBrokerLoginFlowAlias, is:org.json.JSONException: JSONObject["postBrokerLoginFlowAlias"] not found.
06-03 06:54:10.458 INFO  plugin.saml.client.IdpClientFactory IdpClientFactory.java:194- Add/modify IDP idpUrl:https://test.jans.io/kc/admin/realms/jans/identity-provider/instances, isUpdate:false, identityProviderJson:{"internalId":"d0ba4d0d-5ee6-4d3e-af90-b2bf8977abe7","addReadTokenRoleOnCreate":true,"displayName":"KC1","providerId":"saml","alias":"KC!","authenticateByDefault":false,"trustEmail":false,"linkOnly":false,"config":{"validateSignature":"true","signingCertificate":"MIIClzCCAX8CBgGOEnuFaTANBgkqhkiG9w0BAQsFADAPMQ0wCwYDVQQDDARqYW5zMB4XDTI0MDMwNjA2MzYwOFoXDTM0MDMwNjA2Mzc0OFowDzENMAsGA1UEAwwEamFuczCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALF3UvbLQR/mqe2IEd7RTH2bZnZ2uRQtnivXwrOOK4LsChZMIggowMuHqSTihJ7SFRQTtTTPwUFXMSd3UDg/PBlyjUjTxnSS6K4IKN/UPvN0ZtfU0Tzk2dXmP9YFyzkwPxL5Jto/+85PARS/fDne9XxJySbqejsq/8k4/oLr2U+/glFrACzR0GFyW1nc0/WKbY37NtCyBfsBAhpEzHej/xY9hNOWw0swXfHRJ+ocwC/eDZiIOOdKGxfFLTAFCA58FxEcA6YMi1YLlsq4gh/s8H5vcMvTtXaMQgipjWy2gzkSZbA+brqb8EAiI2K2MWHTvc+RtYrxN9gjtUAlZHJgLiECAwEAATANBgkqhkiG9w0BAQsFAAOCAQEAb4e4uMW4JqD9YbZy3AAFQZZLqFJpg9nz14Gwq9fRO2Cyyko2V1iSiqUrSe31b+/0VfBQsPzIZfFFwpQBMq5+5wioFBrOrZ1WFtbMfqgdWwotPQmBSnzbrnv1N0OLzvGCsn7lJMrlEx4TvqqYMtwK6XN4hr8/YuW/ka8UZF9xwtluIssDFhmrdzU4UGvh0cVuuJ+OIRECZOgFEt1PWKmmRtDqtjhIJ8t0O5zImKUK6UA/9rZXJMvEm7QVUbX9vpFRD2efI43Mev5ucriiCpt5sGDg/ZKzRncYE2J5VxtPvmJcxJzqi/DiqUtjcOjffzvHpuc4FgxELgmj0iKtg8XcZQ==","singleSignOnServiceUrl":"https://test.jans.io/kc/realms/jans/protocol/saml","singleLogoutServiceUrl":"https://test.jans.io/kc/realms/jans/protocol/saml","nameIDPolicyFormat":"urn:oasis:names:tc:SAML:2.0:nameid-format:persistent","idpEntityId":"https://test.jans.io/kc/realms/jans"},"enabled":true,"storeToken":true}
06-03 06:54:10.480 ERROR plugin.saml.client.IdpClientFactory IdpClientFactory.java:251- Error while creating/updating IDP - identityProviderJson:{"internalId":"d0ba4d0d-5ee6-4d3e-af90-b2bf8977abe7","addReadTokenRoleOnCreate":true,"displayName":"KC1","providerId":"saml","alias":"KC!","authenticateByDefault":false,"trustEmail":false,"linkOnly":false,"config":{"validateSignature":"true","signingCertificate":"MIIClzCCAX8CBgGOEnuFaTANBgkqhkiG9w0BAQsFADAPMQ0wCwYDVQQDDARqYW5zMB4XDTI0MDMwNjA2MzYwOFoXDTM0MDMwNjA2Mzc0OFowDzENMAsGA1UEAwwEamFuczCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALF3UvbLQR/mqe2IEd7RTH2bZnZ2uRQtnivXwrOOK4LsChZMIggowMuHqSTihJ7SFRQTtTTPwUFXMSd3UDg/PBlyjUjTxnSS6K4IKN/UPvN0ZtfU0Tzk2dXmP9YFyzkwPxL5Jto/+85PARS/fDne9XxJySbqejsq/8k4/oLr2U+/glFrACzR0GFyW1nc0/WKbY37NtCyBfsBAhpEzHej/xY9hNOWw0swXfHRJ+ocwC/eDZiIOOdKGxfFLTAFCA58FxEcA6YMi1YLlsq4gh/s8H5vcMvTtXaMQgipjWy2gzkSZbA+brqb8EAiI2K2MWHTvc+RtYrxN9gjtUAlZHJgLiECAwEAATANBgkqhkiG9w0BAQsFAAOCAQEAb4e4uMW4JqD9YbZy3AAFQZZLqFJpg9nz14Gwq9fRO2Cyyko2V1iSiqUrSe31b+/0VfBQsPzIZfFFwpQBMq5+5wioFBrOrZ1WFtbMfqgdWwotPQmBSnzbrnv1N0OLzvGCsn7lJMrlEx4TvqqYMtwK6XN4hr8/YuW/ka8UZF9xwtluIssDFhmrdzU4UGvh0cVuuJ+OIRECZOgFEt1PWKmmRtDqtjhIJ8t0O5zImKUK6UA/9rZXJMvEm7QVUbX9vpFRD2efI43Mev5ucriiCpt5sGDg/ZKzRncYE2J5VxtPvmJcxJzqi/DiqUtjcOjffzvHpuc4FgxELgmj0iKtg8XcZQ==","singleSignOnServiceUrl":"https://test.jans.io/kc/realms/jans/protocol/saml","singleLogoutServiceUrl":"https://test.jans.io/kc/realms/jans/protocol/saml","nameIDPolicyFormat":"urn:oasis:names:tc:SAML:2.0:nameid-format:persistent","idpEntityId":"https://test.jans.io/kc/realms/jans"},"enabled":true,"storeToken":true}, status:Bad Request, entity:{"error":"Character '!' not allowed."}
06-03 06:54:10.483 ERROR plugin.saml.rest.IdpResource IdpResource.java:218- Application Error while creating IDP is - status:400, message:Error while creating/updating IDP{"internalId":"d0ba4d0d-5ee6-4d3e-af90-b2bf8977abe7","addReadTokenRoleOnCreate":true,"displayName":"KC1","providerId":"saml","alias":"KC!","authenticateByDefault":false,"trustEmail":false,"linkOnly":false,"config":{"validateSignature":"true","signingCertificate":"MIIClzCCAX8CBgGOEnuFaTANBgkqhkiG9w0BAQsFADAPMQ0wCwYDVQQDDARqYW5zMB4XDTI0MDMwNjA2MzYwOFoXDTM0MDMwNjA2Mzc0OFowDzENMAsGA1UEAwwEamFuczCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALF3UvbLQR/mqe2IEd7RTH2bZnZ2uRQtnivXwrOOK4LsChZMIggowMuHqSTihJ7SFRQTtTTPwUFXMSd3UDg/PBlyjUjTxnSS6K4IKN/UPvN0ZtfU0Tzk2dXmP9YFyzkwPxL5Jto/+85PARS/fDne9XxJySbqejsq/8k4/oLr2U+/glFrACzR0GFyW1nc0/WKbY37NtCyBfsBAhpEzHej/xY9hNOWw0swXfHRJ+ocwC/eDZiIOOdKGxfFLTAFCA58FxEcA6YMi1YLlsq4gh/s8H5vcMvTtXaMQgipjWy2gzkSZbA+brqb8EAiI2K2MWHTvc+RtYrxN9gjtUAlZHJgLiECAwEAATANBgkqhkiG9w0BAQsFAAOCAQEAb4e4uMW4JqD9YbZy3AAFQZZLqFJpg9nz14Gwq9fRO2Cyyko2V1iSiqUrSe31b+/0VfBQsPzIZfFFwpQBMq5+5wioFBrOrZ1WFtbMfqgdWwotPQmBSnzbrnv1N0OLzvGCsn7lJMrlEx4TvqqYMtwK6XN4hr8/YuW/ka8UZF9xwtluIssDFhmrdzU4UGvh0cVuuJ+OIRECZOgFEt1PWKmmRtDqtjhIJ8t0O5zImKUK6UA/9rZXJMvEm7QVUbX9vpFRD2efI43Mev5ucriiCpt5sGDg/ZKzRncYE2J5VxtPvmJcxJzqi/DiqUtjcOjffzvHpuc4FgxELgmj0iKtg8XcZQ==","singleSignOnServiceUrl":"https://test.jans.io/kc/realms/jans/protocol/saml","singleLogoutServiceUrl":"https://test.jans.io/kc/realms/jans/protocol/saml","nameIDPolicyFormat":"urn:oasis:names:tc:SAML:2.0:nameid-format:persistent","idpEntityId":"https://test.jans.io/kc/realms/jans"},"enabled":true,"storeToken":true}, Status is Bad Request - {"error":"Character '!' not allowed."} 
devrimyatar commented 6 months ago

This is not an issue. You should not use ! in name, server returned this problem: image

pujavs commented 6 months ago

Right, @MohitMaliFtechiz, as displayed in error message Keycloak Server does not allow ! as displayed in error message that you shared. image

image