Update JanusGraph 0.4 and use testcontainers

marco-scoppetta commented 5 years ago

Hey @farodin91 ,

have you tested these changes? I have no experience with test containers, but testing your version I get the following:

java.lang.UnsatisfiedLinkError: /private/var/folders/8x/4qdbl1_912sc_h2ffjd7wf7m0000gp/T/fdbjni3496103459786540371.library: dlopen(/private/var/folders/8x/4qdbl1_912sc_h2ffjd7wf7m0000gp/T/fdbjni3496103459786540371.library, 1): Library not loaded: libfdb_c.dylib
  Referenced from: /private/var/folders/8x/4qdbl1_912sc_h2ffjd7wf7m0000gp/T/fdbjni3496103459786540371.library
  Reason: image not found

    at java.lang.ClassLoader$NativeLibrary.load(Native Method)
    at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1941)
    at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1824)
    at java.lang.Runtime.load0(Runtime.java:809)
    at java.lang.System.load(System.java:1086)
    at com.apple.foundationdb.JNIUtil.loadLibrary(JNIUtil.java:106)
    at com.apple.foundationdb.FDB.<clinit>(FDB.java:97)

this happens when initialising FoundationDBStoreManager, any idea?

farodin91 commented 5 years ago

You have to install the foundationdb driver before.

marco-scoppetta commented 5 years ago

@farodin91 the FoundationDBStoreManager already uses foundationdb driver, ive updated the POM to use:

<groupId>org.foundationdb</groupId>
<artifactId>fdb-java</artifactId>

am I missing something else?

Ah maybe you're referring to this: https://apple.github.io/foundationdb/api-general.html#installing-client-binaries

Yeah that was it, thanks!

nvvalchev commented 4 years ago

Hello, are there are plans for merging this PR?

theZiki commented 4 years ago

Hi, when we can expect that this will be merged? JanusGraph is now on 0.5.0 version, it's two major versions behind? Tnx

farodin91 commented 4 years ago

@theZiki I don't think will be merged in the current state.

Please stay tuned, @rngcntr is working on an improved version.

rngcntr commented 4 years ago

I can confirm what @farodin91 says ;)

theZiki commented 4 years ago

Can I and my team help you? We are using this in our company and we want to contribute and stay tuned :-)

rngcntr commented 4 years ago

I'm currently working on a fork based on this PR from @farodin91. It already conatins some improvements and you are welcome to contribute

theZiki commented 4 years ago

Do we have a chat on Gitter?

rngcntr commented 4 years ago

Do we have a chat on Gitter?

I've contacted one of the JanusGraph maintainers and asked him to provide a room in their JanusGraph community on Gitter

FlorianHockmann commented 4 years ago

Do we have a chat on Gitter?

JanusGraph has currently only one chat on Gitter but that is mainly used for usage discussions. I think that at least a chat dedicated for development discussions would be helpful and maybe a dedicated chat for this FoundationDB backend, so I suggested that on the janusgraph-dev list. Feel free to voice your opinion their. Until we have dedicated rooms for development, you can of course use the existing JanusGraph room.

theZiki commented 4 years ago

@farodin91 any update about new version of janus?

rngcntr commented 4 years ago

@theZiki We have a new chat room on Gitter which we can use to discuss the FoundationDB storage adapter (among others)

theZiki commented 4 years ago

I'm currently working on a fork based on this PR from @farodin91. It already conatins some improvements and you are welcome to contribute

Hi, I want to contribute, can you please direct me what to do?

rngcntr commented 4 years ago

First of all, thanks for your offer! I didn't work on the project the last few months and there are still two open issues. If you think you can help me with this, feel free to do so ;)

We are currently discussing official support of FoundationDB in JanusGraph over here and here. From what I see, help is also appreciated there

JanusGraph / janusgraph-foundationdb

Update JanusGraph 0.4 and use testcontainers #2