Closed farodin91 closed 4 years ago
Signed-off-by: farodin91 farodin91@googlemail.com
You probably also want to update your name/email settings for this repo and update the signature as per https://github.com/JanusGraph/janusgraph/blob/master/CONTRIBUTING.md#configure-your-repo-to-match-the-cla
@mbrukman It will take some tries until i can finish up this PR.
@farodin91 wrote:
@mbrukman It will take some tries until i can finish up this PR.
No worries, and no rush; please take your time.
Sorry for jumping in on your WIP PR; just wanted to provide some early thoughts for your consideration (but note that I left it as a comment, not a review). Let me know when it's ready for review.
@mbrukman You could start review.
Looks good overall. Can you please add the optional comment for the disabled annotation on all the disabled tests specifying why they are disabled and whether their disablement is temporary or not?
My idea is to create issues for each test case.
@mbrukman I had to deactivate FoundationDBGraphConcurrentTest fully.
Issues are created.
Fixes #19