search

JanusGraph / janusgraph-foundationdb

FoundationDB storage adapter for JanusGraph
Other
53 stars 18 forks source link

Extract range queries and record iterator #46

Closed rngcntr closed 3 years ago

rngcntr commented 4 years ago

Main changes:

  1. Introduce the class FoundationDBRangeQuery

    • This class replaces the old representation of range queries as Object arrays

  2. Extract the FoundationDBRecordIterator into it's own file

    • Unpacking the key-value pairs was also moved to the iterator class to keep the FoundationDBKeyValueStore class clean.
mbrukman commented 4 years ago

@rngcntr — please add a DCO sign-off to your commit and git push -f.

Please see these instructions for how to do it for this PR, and make this automatic in your repo clone for future commits: https://github.com/JanusGraph/janusgraph/blob/master/CONTRIBUTING.md#commit-changes-and-sign-the-developer-certificate-of-origin — I do this for all JanusGraph repos that I clone to avoid forgetting to do this.

rngcntr commented 4 years ago

@mbrukman Sorry I somehow forgot to sign the commit. Thanks for mentioning

rngcntr commented 4 years ago

@mbrukman @blindenvy Would anyone of you like to review this? I did a lot of refactoring here and would prefer to take some of your opinions into account before continuing further development based on these changes.

farodin91 commented 4 years ago

@rngcntr Could you rebase this on top of the master?