parameterised log message, final variable migration, removing unused methods

JanusGraph / janusgraph-foundationdb

FoundationDB storage adapter for JanusGraph

Other

53 stars 18 forks source link

parameterised log message, final variable migration, removing unused methods #60

Closed nischalkumar closed 3 years ago

nischalkumar commented 3 years ago

Small refactor to improve code quality. This pr includes three things

migrating logs to parameterized slf4j error messages
removing unused methods
optimizing imports
a few attributes could be final

linux-foundation-easycla[bot] commented 3 years ago

The committers are authorized under a signed CLA.

:white_check_mark: nischal kumar (345cabf5519bb3933bf701edbf154e616b467b3c)

rngcntr commented 3 years ago

Blocked on #61

nischalkumar commented 3 years ago

That looks good, thanks! Would you please squash your commits into a single one and resolve merge conflicts?

Edit: I just found out about the problems with our testing environment. I will try to go ahead and fix it so that CI will execute correctly.

@rngcntr I have squashed all commits into one. Conflicts are also resolved.

rngcntr commented 3 years ago

@nischalkumar Very nice, thanks a lot for your contribution!