search

JanusGraph / janusgraph-python

JanusGraph Python Gremlin Language Variant (GLV)
Other
22 stars 10 forks source link

Migrate to `testcontainers` from `docker` library for client #36

Closed debasishdebs closed 7 months ago

debasishdebs commented 5 years ago

testcontainers-python is widely used containerization library used for integration tests. The pros of the library docker which is used currently is that, it provides methods to get the host ip which is very much needed to connect to gremlin-server as part of integration tests which is currently retrieved using Popen which is a security venerability.

Also, dotnet library uses the same package ( testcontainers ) for containerization, and hence for consistency, moving python client to testcontainers-python seems a good idea too.

FlorianHockmann commented 7 months ago

No longer valid (the current version uses Testcontainers).