search

JanusGraph / janusgraph

JanusGraph: an open-source, distributed graph database
https://janusgraph.org
Other
5.32k stars 1.17k forks source link

Create Benchmark tests with jmh #1395

Open farodin91 opened 5 years ago

farodin91 commented 5 years ago

I switched janusgraph from junit4 to junit5 during these process. I had to delete some old benchmark tests which are no longer runnable with junit5. These benchmark tests are written with a deprecated framework called com.carrotsearch.junitbenchmarks which is no longer in development.

Therefore, I would prefer to rewrite all with the framework jmh: https://openjdk.java.net/projects/code-tools/jmh/.

farodin91 commented 5 years ago

All tests that are using JUnitBenchmarkProvider need to be replaced. https://github.com/JanusGraph/janusgraph/search?q=JUnitBenchmarkProvider&unscoped_q=JUnitBenchmarkProvider

versaurabh commented 2 years ago

Is this issue closed or any assistance required on this, I can pitch in

li-boxuan commented 2 years ago

@versaurabh It's open and you can see a few TODO issues. Feel free to drop a note on any of them saying you are on it! We could help you if needed.