Documentation mentions nested transactions, but unsupported exceptions thrown

[dont-mind-the-gap]

http://docs.janusgraph.org/0.1.0-SNAPSHOT/tx.html#multi-thread-tx

When trying to use nested transactions, I get an "unsupported feature" exception. Do we need to remove this doc section, implement that support, or is there a configuration option I am missing to enable that feature (if so, it would be great to have that documented in that section).

[pluradj]

The examples in Chapter 9.6 Nested Transactions and in the TinkerPop docs appear to work fine.

I'm guessing you are doing something like this:

gremlin> threadedGraph = graph.tx().createThreadedTx()
==>standardjanusgraphtx[0x54e02f6a]
gremlin> tx = threadedGraph.tx().createThreadedTx()
JanusGraph does not support nested transactions.

The example in Chapter 9.4 Multi-Threaded Transactions work fine, but the variable name threadedGraph is misleading and trailing paragraph is not correct. createThreadedTx() does not return a Graph object, it returns a JanusGraphTransaction. Since you already have a threaded transaction object, you don't need to create another one.

Are you interested in submitting a pull request to fix the doc?

[dont-mind-the-gap]

I need to double check with my company's legal department before I do a pull request. We have a pretty liberal open source policy, but don't want to be wrong :) I'll update again once I verify that I can sign the CLA

[mbrukman]

@dont-mind-the-gap -- please ask your open source legal folks to sign the CCLA (vs. signing the ICLA yourself).

The uncanny resemblance of JanusGraph CLA to the Apache Software Foundation CLA is fully intentional and hopefully makes the review/signature process easier. :-)

[dont-mind-the-gap]

Sent a request to sign the CCLA. Not sure how long it will take, but once its signed I'll create a PR.