IllegalArgumentException raised in a complex query

[Yicheng-Wang]

Please include configurations and logs if available.

For confirmed bugs, please report:

• Version: 0.5.3
• Storage Backend: inmemory
• Mixed Index Backend: none
• Link to discussed bug: none
• Expected Behavior: We have two similar queries with nuance:
  1. "g.E().inV().outE('write').has('duration', eq(0.8446159d).or(outside(0.22740966d,0.029379308d)))"
  2. "g.E().inV().outE('write').has('duration', eq(0.8446159d).or(not(outside(0.22740966d,0.029379308d))))" These queries are illogical, because they are generated randomly just for test. However, we expecte both of them could be accepted in JanusGraph, as both queries within the same code could be accepted in Neo4j.
• Current Behavior: The first query works just fine, while an IllegalArgumentException raised in the second query.

• Steps to Reproduce:

      Vertex bob = g.addV("person").property("name", "Bob").next();
      Vertex alice = g.addV("person").property("name", "Alice").next();
      Vertex book = g.addV("book").property("name", "book1").next();
  
      Edge edge1 = g.addE("knows").from(bob).to(alice).next();
      Edge edge2 = g.addE("write").from(alice).to(book).next();
      g.E(edge2).property("duration", new Double(0.94461)).iterate();
  
      String query1 = "g.E().inV().outE('write').has('duration', eq(0.8446159d).or(outside(0.22740966d,0.029379308d)))";
  
      try{
          List<Result> results = connection.getClient().submit(query1).all().get();
          for (Result r : results) {
              System.out.println(r);
          }
      }catch (Exception e){
          e.printStackTrace();
      }
  
      String query2 = "g.E().inV().outE('write').has('duration', eq(0.8446159d).or(not(outside(0.22740966d,0.029379308d))))";
  
      try{
          List<Result> results = connection.getClient().submit(query2).all().get();
          for (Result r : results) {
              System.out.println(r);
          }
      }catch (Exception e){
          e.printStackTrace();
      }
      finally {
          System.exit(0);
      }

  Stack Trace (if you have one)

java.util.concurrent.ExecutionException: org.apache.tinkerpop.gremlin.driver.exception.ResponseException: java.lang.IllegalArgumentException
    at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
    at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
    at org.gdbtesting.janusgraph.JanusGraphConnection.main(JanusGraphConnection.java:160)
Caused by: org.apache.tinkerpop.gremlin.driver.exception.ResponseException: java.lang.IllegalArgumentException
    at org.apache.tinkerpop.gremlin.driver.Handler$GremlinResponseHandler.channelRead0(Handler.java:260)
    at org.apache.tinkerpop.gremlin.driver.Handler$GremlinResponseHandler.channelRead0(Handler.java:200)
    at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
    at org.apache.tinkerpop.gremlin.driver.Handler$GremlinSaslAuthenticationHandler.channelRead0(Handler.java:126)
    at org.apache.tinkerpop.gremlin.driver.Handler$GremlinSaslAuthenticationHandler.channelRead0(Handler.java:68)
    at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
    at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
    at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
    at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:93)
    at io.netty.handler.codec.http.websocketx.Utf8FrameValidator.channelRead(Utf8FrameValidator.java:82)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
    at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
    at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:324)
    at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:296)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
    at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
    at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:714)
    at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:650)
    at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:576)
    at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)
    at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
    at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
    at java.lang.Thread.run(Thread.java:748)

[porunov]

Confirmed this bug with master branch (0.6.0). Tried the above queries with TinkerGraph and they work there but fail with JanusGraph.

[li-boxuan]

I can confirm it too. Seems this is because JanusGraph requires the condition to be in QNF form. QNF for JanusGraph is a variant of CNF (conjunctive normal form) with negation inlined where possible. The failed query is translated into

eq(0.8446159d) OR (>= 0.22740966d AND <= 0.029379308d) which is not in QNF form, thus the exception.

At the moment I am not sure why JanusGraph requires QNF form...

UPDATE: all tests pass when I remove QNF checks: df4a5da0614927267cf1721a61bd2e973dedb2c7

[Yicheng-Wang]

I can confirm it too. Seems this is because JanusGraph requires the condition to be in QNF form. QNF for JanusGraph is a variant of CNF (conjunctive normal form) with negation inlined where possible. The failed query is translated into

eq(0.8446159d) OR (>= 0.22740966d AND <= 0.029379308d) which is not in QNF form, thus the exception.

At the moment I am not sure why JanusGraph requires QNF form...

UPDATE: all tests pass when I remove QNF checks: df4a5da

Thanks for your response~ While we encountered another query which raises IllegalArgumentException, here is an example to reproduce:

        Vertex Moly = g.addV("student").property("grade", 9).next();
        Vertex notebook = g.addV("homework").property("subject", "Math").next();

        Edge edge1 = g.addE("write").from(Moly).to(notebook).property("date","19980604").next();

        String query0 = "g.E().has('date',inside('19980601','19980630').or(lt('19980101')))";
        String query1 = "g.V().bothE('write').has('date',inside('19980601','19980630').or(lt('19980101')))";

query0 works, while query1 raises IllegalArgumentException just as original issue, not sure whether they are caused by the same problem, so we ask here first, could you please help us with this? @li-boxuan

[li-boxuan]

@Yicheng-Wang It is likely the same issue because I cannot reproduce it on master. Can you build JanusGraph again using latest master branch and try?

[Yicheng-Wang]

@Yicheng-Wang It is likely the same issue because I cannot reproduce it on master. Can you build JanusGraph again using latest master branch and try?

Thanks for your reply, maybe we will try using the next release.