JanusGraph / janusgraph

JanusGraph: an open-source, distributed graph database
https://janusgraph.org
Other
5.26k stars 1.16k forks source link

Increase maven wget timeout for ElasticSearch and Cassandra to 30 minutes #4419

Closed porunov closed 4 months ago

porunov commented 4 months ago

Often times I see read timeout during janusgraph-distribution building process in GitHub Actions. It seems mostly it happens while downloading ElasticSearch or Cassandra. It usually downloads the packages almost fully (like ~80%) but then for some of the files parts the timeout happens which prevent build from passing. The was no any default timeout prior to 1.7.0 release of maven-download plugin, but starting from 1.7.0 the default timeout is 3 seconds. This PR sets readTimeOut for ElasticSearch and Cassandra downloads up to 30 minutes. Alternatively, we could remove timeout as it was previously, but knowing that the GitHub Action will timeout in 60 minutes anyways it seems unreasonable to having this timeout more than 30 minutes. I'm also OK setting it to lower values or remove timeout at all if you think it makes sense. See configuration options here: https://maven-download-plugin.github.io/maven-download-plugin/docsite/1.9.0/wget-mojo.html


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

For code changes:

For documentation related changes:

janusgraph-automations commented 4 months ago

💚 All backports created successfully

Status Branch Result
v1.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details