search

JanusGraph / janusgraph

JanusGraph: an open-source, distributed graph database
https://janusgraph.org
Other
5.28k stars 1.16k forks source link

cannot drop janusgraph_vertices index when using external mappings. #805

Open CJSoldier opened 6 years ago

CJSoldier commented 6 years ago

I'm using cassandra 3.11 and ES 5.x with janusgraph 0.2.1.

I open graph with the following two parameters configured and then call JanusGraphFactory.drop. 

baseConfiguration.setProperty("index.search.elasticsearch.use-all-field", false);
baseConfiguration.setProperty("index.search.elasticsearch.create.use-external-mappings", true);
graph = JanusGraphFactory.open(baseConfiguration);
...
JanusGraphFactory.drop(graph);

Only keyspace janusgraph being removed. Is it correct to remove janusgraph keyspace and janusgraph_vertices index manually?

davidclement90 commented 6 years ago

I think it's a bug because drop call Backend clearStorage which call IndexProvider clearStorage https://github.com/JanusGraph/janusgraph/blob/ed532e0d64e8f53953c8967e1c9f161abdfdb146/janusgraph-core/src/main/java/org/janusgraph/diskstorage/Backend.java#L592