cannot update list property when value contains special characters

[CJSoldier]

I have a list property with composite index and mixed index built.

// build composite and mixed indexes

JanusGraphTransaction tx = graph.newTransaction();
JanusGraphVertex vertex1 = tx.addVertex(T.label, "Person");
vertex1.property("Person_emailList", "\"aa@qq.com\t");
long id = vertex1.longId();
System.out.println("id="+id);
tx.commit();
tx = graph.newTransaction();
Vertex vertex2 = tx.getVertex(id);
// str ends with a tab character
String str = "\"bb@qq.com   ";
vertex2.property("Person_emailList", str);
tx.commit();

java.io.IOException: Failure(s) in Elasicsearch bulk request: {type=illegal_argument_exception, reason=failed to execute script, caused_by={type=script_exception, reason=compile error, script_stack=[... ["Person_emailList"].add("\"bb@qq.com\t");,                              ^---- HERE], script=if(ctx._source["Person_emailList"] == null){ctx._source["Person_emailList"] = [];}ctx._source["Person_emailList"].add("\"bb@qq.com\t");, lang=painless, caused_by={type=illegal_argument_exception, reason=unexpected character ["\"bb@qq.com\t]. The only valid escape sequences in strings starting with ["] are [\\] and [\"]., caused_by={type=lexer_no_viable_alt_exception, reason=null}}}}
    at org.janusgraph.diskstorage.es.rest.RestElasticSearchClient.bulkRequest(RestElasticSearchClient.java:274)

in getAdditionScript method, my update script is like this:

if(ctx._source["Person_emailList"] == null){ctx._source["Person_emailList"] = [];}ctx._source["Person_emailList"].add("\"bb@qq.com\t");

in bulkRequest method, after outputStream.write(mapWriter.writeValueAsBytes(request.getSource())); the script goes like this:

{"update":{"_index":"janusgraph_vertices","_type":"vertices","_id":"39s"}}
{"script":{"source":"if(ctx._source[\"Person_emailList\"] == null){ctx._source[\"Person_emailList\"] = [];}ctx._source[\"Person_emailList\"].add(\"\\\"bb@qq.com\\t\");","lang":"painless"},"upsert":{"Person_emailList":["\"bb@qq.com\t"]}}

I thought it was an ES bug. But they say it's not. painless cannot parse escaped characters correctly

I cannot step into outputStream.write method, so I changed getAdditionScript method like this and then I got the script I wanted.:

script.append("if(ctx._source[\"" + e.field + "\"] == null){ctx._source[\"" + e.field + "\"] = [];}");
                    script.append("ctx._source[\"").append(e.field).append("\"].add(").append(convertToPainlessType(e.value, compat.scriptLang(), Mapping.getMapping(keyInformation))).append(");");
                    if (hasDualStringMapping(keyInformation)) {
                        String mappingName = getDualMappingName(e.field);
                        script.append("if(ctx._source[\"" + mappingName + "\"] == null){ctx._source[\"" + mappingName + "\"] = [];}");
                        script.append("ctx._source[\"").append(mappingName).append("\"].add(").append(convertToPainlessType(e.value, compat.scriptLang(), Mapping.getMapping(keyInformation))).append(");");
                    }

private static String convertToPainlessType(Object value, String scriptLang, Mapping mapping) throws PermanentBackendException {
        final String esValue;
        try {
            if(value instanceof String) {
                esValue = "'"+value+"'";
            } else {
                esValue = mapWriter.writeValueAsString(convertToEsType(value, mapping));
            }
        } catch (final Exception e) {
            throw new PermanentBackendException("Could not write json");
        }
        return scriptLang.equals("groovy") ? esValue.replace("$", "\\$") : esValue;
    }

[davidclement90]

With version of Janus and ES to you use ?

[CJSoldier]

janusgraph0.2.1 and ES5.6.3. Should we use single quotation marks?