search

Janzert / AEI

The Arimaa Engine Interface provides a standard method to communicate and control an Arimaa bot.
http://arimaa.janzert.com/aei/
Other
22 stars 5 forks source link

Convert code to Python 3 with "2to3". #6

Closed TFiFiE closed 3 years ago

TFiFiE commented 3 years ago

After running 2to3 on the code, commit e796f134880e499622c1c9a535f21e30f342d1c3 still had to be manually undone.

Janzert commented 3 years ago

Thanks for giving this a go. A few years ago I started work on getting this ported, got busy and never got back to it. My guess is the biggest issue for porting to sort out is the better separation of strings and bytes in python3. To aid in finding those and other issues I had started working on at least somewhat more comprehensive tests (apparently I stalled out in the middle of working on the board module without even committing the work done). Running even the partial tests that are here though seems to confirm str vs bytes as a primary issue with a few of them failing on str being passed when expecting bytes. Let me see what I can get done with it this weekend.

TFiFiE commented 3 years ago

It looks like you want to maintain Python 2 compatibility. Are you sure it's worth it?

Janzert commented 3 years ago

Yep. So far keeping python 2.7 compatibility has been pretty simple. The actual making it run correctly and getting all tests passing with no warnings on python 3 has certainly been the harder part. It's also been handy to go back and forth between 2 and 3 to test.