Japan-Digital-Archives / Japan-Digital-Archive

Digital Archive of Japan's 2011 Disasters
6 stars 18 forks source link

My collection page: dragged items are not loading, cannot edit. #1017

Closed jdaKoko closed 8 years ago

jdaKoko commented 8 years ago

@meeshmon @jcuanm 1.) Items are not loading to collection pages 2.) Editing function is not working http://jdarchive.org/en/collection/1998442 screen shot 2015-10-29 at 6 42 05 am

meeshmon commented 8 years ago

Also @rchen152 and @horak can one of you take a look?

rchen152 commented 8 years ago

Wondering if it might be this: https://theeventscalendar.com/support/forums/topic/uncaught-invalidvalueerror-not-an-object/ If you go to http://dev.jdarchive.org/rebecca/web/en/search#view_type=thumb&media_type=Collection& and try to load some of the collections, the first three are just fine, while the fourth one (http://dev.jdarchive.org/rebecca/web/en/collection/884991) causes the error Uncaught InvalidValueError: not an Object to be logged to the console, and the editing and item loading are broken.

rchen152 commented 8 years ago

Ok, I'm not getting anywhere with this - will come back to it in a few days when I have more time. If anyone else wants to take a look in the meantime, the snippet of code that causes the error to be thrown is the following from web/js/app/views/items/jda.view.item.collection-page.js: new google.maps.LatLng(this.model.get("media_geo_latitude"),this.model.get("media_geo_longitude"))

It blows up when this.model.get("media_geo_latitude") or this.model.get("media_geo_longitude") is null, but I'm not sure how to determine whether (1) a change to the GoogleMaps API caused the values to be incorrectly set to null elsewhere, and this is just one symptom of the problem, or (2) the values are indeed supposed to be null, and the problem is just that google.maps.LatLng used to accept null values and no longer does (so we need to check for them ourselves).

rchen152 commented 8 years ago

Ryo and I troubleshooted this during today's tech meeting, and it should be fixed now.

jdaKoko commented 8 years ago

Thank you!