JarHax / Prestige

A mod that allows progress to transfer between worlds.
GNU Lesser General Public License v2.1
1 stars 6 forks source link

[Weird bug] Prestige fired command award randomly gains +1 when fired, but sometimes doesn't. #23

Open Darkmega18 opened 4 years ago

Darkmega18 commented 4 years ago

G'day, I'm currently in the process of making a modpack called "Timeless Technician". I'm using prestige to have a type of start of game bonus equipment point spending system. It's mostly related to buffing your starting equipment so you have less issues getting off the ground and surviving.

But, I have all rewards set as give commands at the player to give them one or two bundles of items in question. like a piece of armor or a bundle of a certain kind of supply etc. But sometimes frequently, sometimes infrequently when the command fires it gives +1 of the item in question but nothing in the crafttweaker log, or console gives an indication that there should have been a bonus item.

The item is also noticeable because give commands go straight into inventory, where as the accidental +1s are instead dropped FROM the player onto the floor infront as if the item was dropped by them. So sometimes i might do the prestige that gives 10 gardens of the selected kind (6 different prestiges, that give 10 of each, sent to the player when the screen closes, as that seems to be the time all the rewards fire). I'll get 10 of each just fine, but one or two of them, random usually, will have the bug occur where a spare garden will drop infront and I'll end up with total 11.

This is worse when it comes to armors and tools because at random now they can have twice the suit or armor, or two doggy talent dogs or tools etc.

I'm not sure what is causing it, whether it's a coding bug, script bug, lag issue, phantom player of some kind or whatever.

but if it's anything to go off, sometimes very rarely when getting a large amount of stuff out of prestige coincidental with when the items are dropping from me a crash will occur from genetics reborn related to a concurrent modification and something about checking lights. https://paste.dimdev.org/exuyejuges.mccrash

Here is the log to my minecraft currently after the crash. I was doing a few rounds with the prestige stuff in game, getting them, getting gear, seeing what duped, clearing, getting more prestige then doing it again to see what gets duped again. each time it was different, but it always only showed the right amount of commands going off. Although there is something about a shader failing somewhere during the loading that I noticed...

latest.log

But I'll probably also bring the crash that occurred to genetics reborn now.

Crucial versioning info: Minecraft 1.12.2 forge: -14.23.5.2847 Modpack: Timeless Technician version 0.1.2 for modlist and if you want to load it and try stuff against it. Prestige: 1.1.51 Crafttweaker: 1.12-4.1.20.564

Darkmega18 commented 4 years ago

The concurrent modification crash still occasionally occurs even with the crash reported portion pertaining to genetics reborn being fixed. I'm not sure what else to go to now.

Can the issue be related to firing too many prestige rewards at the same time?