search

Jarada / WuufusWaygates

Spigot Plugin: Wuufu's Waygates is a gate plugin inspired by Creative Gates and Stargate that allows players to connect gates into networks using any material and without any commands
https://www.spigotmc.org/resources/wuufus-waygates.80094/
GNU General Public License v3.0
8 stars 4 forks source link

Portal create to much particles #16

Closed FurrO2 closed 12 months ago

FurrO2 commented 12 months ago

Hello, i have this weird bug and i don't know how to fix it : the bug is, there is too much particles on the 3x3 portal ( near 2800 ) compare to the 2x3 ( 230 particles ~) image image

I'm using paper on 1.20.1, and the latest version of this plugins ( 1.4.1 ).

FurrO2 commented 12 months ago

image image 2023-11-17_18 20 42

Jarada commented 12 months ago

Hi there, thank you for this bug report.

Can you answer a few questions?

  1. Does this issue exist on all 3x3 gates?
  2. Does this issue persist even on server restarts?
  3. What is the config setting WG_GATE_EFFECT_PARTICLES?

Thanks!

FurrO2 commented 12 months ago

1 : After some tests, it appears that this bug can also manifest on other shape of portals.

2: Yes, even after deleting the configuration file.

3:

  MAX_AREA: 200
  MENU_SIZE: compact
  WG_NAME_MAX_LENGTH: 18
  WG_DESC_MAX_LENGTH: 100
  WG_NETWORK_NAME_MAX_LENGTH: 18
  WG_CONTROLLER_DISTANCE: 50
  WG_GATE_ACTIVATION_TIME: 20
  WG_GATE_EFFECT_PARTICLES: normal
  WG_GATE_MINIMAL_DISTANCE: 1
  WG_GATE_ICON_CHANGE_CONSUMES: false
  WG_CONTROL_CREATOR_CONSUMES: true
  WG_CONSTRUCTOR_CONSUMES: true
  WG_KEY_CONSUMES: false
  WG_KEY_PERMANENT: false
  WG_ZOMBIE_PIGMAN_ALLOWED: false
  WG_PRIVATE_GATES_ALLOW_TRAVEL: false
  BLOCKS_REQUIRED:
    '1':
      EMERALD_BLOCK: 2
FurrO2 commented 12 months ago

image

( 1 more exemple )

Jarada commented 12 months ago

Thanks. I'm going to have a deeper dive on this tomorrow, but if you can, are you able to check if this version fixes the underlying problems?

WuufusWaygates-1.4.1.1.jar.zip

FurrO2 commented 12 months ago

image

this time, with fresh new portals, there is no particles but when the portal is working

FurrO2 commented 12 months ago

image Apologies, that was a mistake on my part. There's actually only one portal where the particles function correctly. When I enter it, the particles disappear and reappear at the next portal.

FurrO2 commented 12 months ago

After some more testing, when 2 portals have the magic particle, the last one that was modified to emit the magic particles displays them, but the others are removed.

Jarada commented 12 months ago

Thank you, this was very helpful in diagnosing the issue. I am fairly certain that this should fix the issue and you should get a good number of particles staying on all portals.

WuufusWaygates-1.4.1.2.jar.zip

FurrO2 commented 12 months ago

i Confirm, this update fix the issue , but when i spam the button for switching particle type, there is some spam in the logs like this : https://log.mtxserv.com/Nu27lfl [INFO] [WuufusWaygates] Current Size 20

And i discover some minor bug, should i report them here or create another ticket ?

Jarada commented 12 months ago

Thanks for the update! I'm glad this fixes the issue. Apologies for the spam, that was some logs I was using to debug.

I've removed those logs and made the particle effects feel less "pulse" like in this update.

WuufusWaygates-1.4.1.3.jar.zip

If you have another bug related to gate particle effects, then feel free to report them here, otherwise another ticket would be beneficial.

FurrO2 commented 12 months ago

okay, i'm gonna create a ticket :)